Paul assistant #1342
Open
Paul assistant #1342
+1,682
−39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e the dropdownlist to a list
…) and display assistant profile in header
willydouhard
commented
Sep 16, 2024
backend/chainlit/__init__.py
Outdated
| @@ -402,6 +427,9 @@ def acall(self): | |||
| "TaskStatus", | |||
| "Video", | |||
| "ChatSettings", | |||
| "AssistantSettings", | |||
| # assistant | |||
There was a problem hiding this comment.
remove comment
| @@ -0,0 +1,16 @@ | |||
| from typing import List, Dict | |||
There was a problem hiding this comment.
if we have multiple assistant file it can be in a dedicated folder/module
backend/chainlit/server.py
Outdated
| StaticFiles(directory="public", check_dir=False), | ||
| name="public", | ||
| ) | ||
| # app.mount( |
There was a problem hiding this comment.
Why is this commented?
backend/chainlit/server.py
Outdated
| Union[None, User, PersistedUser], Depends(get_current_user) | ||
| ], | ||
| ): | ||
| # if not current_user: |
There was a problem hiding this comment.
why is this commented?
| @@ -40,6 +41,7 @@ const Header = memo(() => { | |||
| }} | |||
| > | |||
| <ChatProfiles /> | |||
| <SelectedAssistantDisplay /> | |||
There was a problem hiding this comment.
can chat profiles co exist with assistants?
There was a problem hiding this comment.
they should not, but it will simply be specified in the README (or/and the doc)
| const enableHistory = !!user.accessToken && !!config?.dataPersistence; | ||
|
|
||
| useEffect(() => { | ||
| if (isMobile) { | ||
| setChatHistoryOpen(false); | ||
| } else { | ||
| setChatHistoryOpen(enableHistory); | ||
| setChatHistoryOpen(true); |
There was a problem hiding this comment.
we should use enableHistory and include assistants in it
…assistants features
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.