Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial MongoDB Data Layer commit #1171

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

Pash10g
Copy link

@Pash10g Pash10g commented Jul 28, 2024

Hello,

Adding a MongoDB type for custom data layer support.

Can someone guide me on how to contribute the docs to incorporate this piece?

Thanks!

@dokterbob dokterbob added the data layer Pertains to data layers. label Aug 14, 2024
@Pash10g
Copy link
Author

Pash10g commented Aug 20, 2024

It needs a motor depndency, how do I add it into the project?

CC : @dokterbob

@dokterbob
Copy link
Collaborator

@Pash10g Thanks for the contrib!

In order to make it easier for developers to contribute data layers, we will soon factor out all data layers (except the ephemeral one and possibly LiteralAI) into a separate project/repo. In this, our first priority would be automated testing (unit tests) to be able to ensure compliance of new backends.

We're still busy doing the architecture on that one, which will take some 2-6 weeks. Until that time, we prefer not to add additional data layers, as every piece of code we add will imply increased maintenance load on our side.

In addition, we prefer to be very cautious in terms of adding dependencies. In addition, given that you are not currently comfortable adding (optional) dependencies, perhaps for the moment it's best to leave your PR as a reference, for now, until we have a straight-forward (and documented) way of integrating your contributions.

@dokterbob
Copy link
Collaborator

Thanks for understanding this, we do value your contribution, just we're focusing at the moment on making contributions overall easier, for everyone while keeping maintenance easier on the maintainer's side. :)

@dokterbob dokterbob added the bug Something isn't working label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working data layer Pertains to data layers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants