Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix linting rule lint/style/noUselessElse #476

Draft
wants to merge 30 commits into
base: master
Choose a base branch
from
Draft
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
b53c70f
Add biome deps
nazarhussain Mar 14, 2025
b6d8ad4
Remove all eslint disable directives
nazarhussain Mar 14, 2025
eeec80e
Fix import orders
nazarhussain Mar 14, 2025
07489bf
Fix all formatting issues
nazarhussain Mar 14, 2025
50b64f1
Fix lint/suspicious/noDoubleEquals
nazarhussain Mar 14, 2025
5d0c3b9
Fix lint/suspicious/noExplicitAny
nazarhussain Mar 14, 2025
b07f52f
Fix lint/suspicious/noImplicitAnyLet
nazarhussain Mar 14, 2025
ed8be2e
Fix lint/suspicious/noShadowRestrictedNames
nazarhussain Mar 14, 2025
9177249
Fix lint/suspicious/useGetterReturn
nazarhussain Mar 14, 2025
3f8aa7b
Fix lint/suspicious/noGlobalIsNan
nazarhussain Mar 14, 2025
c692f9c
Fix lint/suspicious/noAssignInExpressions
nazarhussain Mar 14, 2025
9d367fd
Fix lint/suspicious/noExportsInTest
nazarhussain Mar 14, 2025
150aba7
Fix lint/complexity/useArrowFunction
nazarhussain Mar 14, 2025
7cc4528
Fix lint/complexity/noThisInStatic
nazarhussain Mar 14, 2025
8098303
Fix lint/complexity/useLiteralKeys
nazarhussain Mar 14, 2025
bd50c53
Fix lint/complexity/noForEach
nazarhussain Mar 14, 2025
cd79c36
Fix lint/complexity/noUselessTernary
nazarhussain Mar 14, 2025
a82fb2b
Fix lint/correctness/noUnusedVariables
nazarhussain Mar 14, 2025
9ab6aaa
Fix lint/correctness/noVoidTypeReturn
nazarhussain Mar 14, 2025
824cbf3
Fix lint/correctness/noUndeclaredVariables
nazarhussain Mar 14, 2025
aca3255
Fix lint/nursery/useConsistentMemberAccessibility
nazarhussain Mar 14, 2025
71ae25f
Fix lint/nursery/useCollapsedIf
nazarhussain Mar 14, 2025
f8cfdd8
Fix lint/nursery/useGuardForIn
nazarhussain Mar 14, 2025
556d18c
Fix lint/nursery/useAtIndex
nazarhussain Mar 14, 2025
4ad6b50
Fix lint/style/noVar
nazarhussain Mar 14, 2025
6ff70bf
Fix lint/style/useEnumInitializers
nazarhussain Mar 14, 2025
16e352f
Fix lint/style/noNonNullAssertion
nazarhussain Mar 14, 2025
e9d4f78
Fix lint/style/useNodejsImportProtocol
nazarhussain Mar 14, 2025
3b4ed36
Fix lint/style/useNumberNamespace
nazarhussain Mar 14, 2025
69d0eba
Fix lint/style/noUselessElse
nazarhussain Mar 14, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix lint/suspicious/noShadowRestrictedNames
nazarhussain committed Mar 14, 2025
commit ed8be2e2772f21ca3a07124181c4b13f09761348
1 change: 1 addition & 0 deletions packages/ssz/test/lodestarTypes/phase0/sszTypes.ts
Original file line number Diff line number Diff line change
@@ -39,6 +39,7 @@ const {
} = preset;

const {
// biome-ignore lint/suspicious/noShadowRestrictedNames: It is required to use `Boolean` name as type
Boolean,
Bytes32,
UintNum64,
1 change: 1 addition & 0 deletions packages/ssz/test/lodestarTypes/phase0/validator.ts
Original file line number Diff line number Diff line change
@@ -3,6 +3,7 @@ import {ContainerNodeStructType} from "../../../src/type/containerNodeStruct.js"
import {ValueOfFields} from "../../../src/view/container.js";
import * as primitiveSsz from "../primitive/sszTypes.js";

// biome-ignore lint/suspicious/noShadowRestrictedNames: It is required to use `Boolean` name as type
const {Boolean, Bytes32, UintNum64, BLSPubkey, EpochInf} = primitiveSsz;

// this is to work with uint32, see https://github.com/ChainSafe/ssz/blob/ssz-v0.15.1/packages/ssz/src/type/uint.ts
1 change: 1 addition & 0 deletions packages/ssz/test/lodestarTypes/primitive/sszTypes.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import {BooleanType, ByteVectorType, UintBigintType, UintNumberType} from "../../../src/index.js";

// biome-ignore lint/suspicious/noShadowRestrictedNames: It is required to use `Boolean` name as type
export const Boolean = new BooleanType();
export const Byte = new UintNumberType(1);
export const Bytes4 = new ByteVectorType(4);