Skip to content

fix(parachain): use correct type for ErasureChunk.Proof #4670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Apr 23, 2025

Conversation

haikoschol
Copy link
Contributor

Changes

This PR changes the type of availabilitystore.ErasureChunk.Proof from []byte to [][]byte.

Additionally it adds the function erasure.BranchHash() and uses it in the availability distribution subsystem to validate erasure chunks retrieved by fetchChunkTask objects.

Tests

go test ./lib/erasure
go test ./dot/parachain/availability-distribution

Issues

#4597

Copy link
Member

@freddyli7 freddyli7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@haikoschol haikoschol merged commit ca6db9d into feat/parachain Apr 23, 2025
22 checks passed
@haikoschol haikoschol deleted the haiko/fix-erasure-chunk branch April 23, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants