chore: replace eslint and prettier with biomejs #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazarhussain
force-pushed
the
nh/biomejs
branch
from
7e92b27 to
b7a96df
Compare
Performance Report✔️ no performance regression detected Full benchmark results
|
matthewkeil
requested changes
Mar 26, 2025
nazarhussain
commented
Mar 26, 2025
| @@ -13,7 +13,7 @@ export async function getCurrentCommitInfo(): Promise<{ | |||
| const branchStr = await shell("git branch --show-current"); | |||
| const timestamp = parseInt(timestampStr, 10); | |||
|
|
|||
| if (!timestamp || isNaN(timestamp)) { | |||
| if (!timestamp || Number.isNaN(timestamp)) { | |||
There was a problem hiding this comment.
@matthewkeil This usage is different than the Number namespace rule. This is safety fix as the behavior of global isNaN and Number.isNaN is different. Global instance coerce the input to number before checking it, later one check what the given input is.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Use the advance and consistent tooling across the repos.
Description
Steps to test or reproduce