Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add foundational CUDA support and basic kernel #459

Draft
wants to merge 23 commits into
base: main
Choose a base branch
from
Draft

Add foundational CUDA support and basic kernel #459

wants to merge 23 commits into from

Conversation

corybarr
Copy link
Contributor

@corybarr corybarr commented Aug 28, 2023 •
edited

This PR add the foundational classes for adding CUDA kernels to tilesets. In this initial implementation, a selectable kernel is created per tile. Notes:

  • If you want to see the placeholder kernel's output to verify it's working, uncomment the print statement in CudaKernels.h::createVoxelsKernel
  • This PR runs only a placeholder kernel. The next PR will finalize handling the arguments non-trivial kernels need per type.
  • There is a test USDA file that will start to load the Melbourne point-cloud dataset
  • Note that the base branch is add-cuda-cmake, not main
  • This PR also contains code to pass the geometric error per tile down to a tile for later use in kernels

melbournePointCloudTileset.zip

corybarr and others added 19 commits August 22, 2023 11:57
@corybarr
check in partially completed, need kernel to continue
08421f2
@corybarr
fix merge conflict
a0bcc4e
@corybarr
add stub of CudaManager.h
1289ce1
@lilleyse
Revert "Remove cuda from build. No longer needed for Kit 105"
2cc510b 
This reverts commit b27e570.
@corybarr
Fix all compilation errors
7dbbc2b
@corybarr
Merge branch 'main' of github.com:CesiumGS/cesium-omniverse into add-…
6477098 
…cuda
@corybarr
update extern/CMakeLists.txt
b06bbb1
@corybarr
add nvrtc and cuda to CMakeLists.txt
d5546b2
@corybarr
manually revert commit 34e6e3f
1c3c770
@corybarr
add in tileId
c844568
@corybarr
enable basic print-to-screen kernel
ab04c1f
@corybarr
run placeholder kernel for every tile
18422c3
@corybarr
merge with add-cuda-cmake
0324bd4
@corybarr
remove cudart from CMakeLists.txt
3e37801
@corybarr
delete CudaRunners when tile is freed
643f76d
@corybarr
clang formatting fixes
f0ec135
@corybarr
cosmetic
701b60b
@corybarr
clean up CudaManager.h
f8a62f5
@corybarr
clean up CudaManager
8313f49
@corybarr corybarr changed the base branch from main to add-cuda-cmake August 28, 2023 19:14
corybarr
corybarr commented Aug 28, 2023
View reviewed changes
src/core/include/cesium/omniverse/CudaManager.h
CudaKernelArgs args,
int elementCount)
: kernelType(cudaKernelType)
, kernelArgs(std::move(args))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This clang convention of starting with a comma seems odd. Is this correct?

corybarr
corybarr commented Aug 28, 2023
View reviewed changes
src/core/include/cesium/omniverse/CudaManager.h
int elementCount;

private:
// omni::fabric::PrimBucketList _bucketList;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Placeholder for incorporating the kernel args in the next PR.

corybarr
corybarr commented Aug 28, 2023
View reviewed changes
src/core/include/cesium/omniverse/CudaManager.h
void runAllRunners();
void initialize();
void runRunner(CudaRunner& runner);
void** packArgs(CudaKernelArgs cudaKernelArgs, CudaKernelType cudaKernelType);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Placeholder for next PR. Signature might change.

@corybarr corybarr marked this pull request as ready for review August 28, 2023 19:19
@weegeekps
Copy link
Contributor

@corybarr @lilleyse Does this need to be merged prior to the release on Friday?

@corybarr corybarr marked this pull request as draft August 29, 2023 19:20
Base automatically changed from add-cuda-cmake to main September 5, 2023 19:14
This was referenced Oct 2, 2023
Merged
Merged
@lilleyse lilleyse mentioned this pull request Oct 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lilleyse lilleyse Awaiting requested review from lilleyse

@weegeekps weegeekps Awaiting requested review from weegeekps

@r-veenstra r-veenstra Awaiting requested review from r-veenstra

@mattelser mattelser Awaiting requested review from mattelser

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@corybarr @weegeekps @lilleyse