Skip to content

CERT-8473 | Add a flag for adding a pr comment only when failing #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 3, 2025

Conversation

ozcodes
Copy link
Collaborator

@ozcodes ozcodes commented Mar 31, 2025

Add support for choosing whether to add a comment to the pr always or only when the run fail.

@ozcodes ozcodes requested review from H00N24 and fnast9 March 31, 2025 12:28
@fnast9
Copy link
Collaborator

fnast9 commented Mar 31, 2025

Who asked for that change and why?

@ozcodes
Copy link
Collaborator Author

ozcodes commented Mar 31, 2025

Who asked for that change and why?

It was requested by some certora users, there is also a ticket for it:
https://certora.atlassian.net/browse/CERT-8473

@ozcodes ozcodes changed the title Add a flag for adding a pr comment only when failing CERT-8473| Add a flag for adding a pr comment only when failing Mar 31, 2025
@ozcodes ozcodes changed the title CERT-8473| Add a flag for adding a pr comment only when failing CERT-8473 | Add a flag for adding a pr comment only when failing Mar 31, 2025
Copy link
Collaborator

@H00N24 H00N24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GJ, just one small thing. Please add a description for this flag to README.md.

action.yml Outdated
@@ -81,6 +81,10 @@ inputs:
default: "false"
description: |-
Whether to only run the compilation steps. Default is `false`.
comment-fail-only:
default: "false"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can use "true" as the default value.

Suggested change
default: "false"
default: "true"

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed the default and added a description to the readme file.

@H00N24 H00N24 merged commit b814a02 into main Apr 3, 2025
1 check passed
@H00N24 H00N24 deleted the oz/comment-fail-only branch April 3, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants