Remove requirement for meta-modules #102
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the need for meta-module declaration by scanning workspaces during initialization.
This scanning step attempts to discover a clerk file per workspace and analyze its hierarchy and inclusion rules so that error in included files are propagated correctly which was previously done by manual declaration (as clerk meta-modules which we aim to remove).
This work still lacks some dynamic features that allow to maintain a consistent project hierarchy that I aim to improve as we properly define a structure for a Catala/clerk project.
Also, it displays a proper error when a module usage is ambiguous (i.e., when two modules with the same names are valid candidates)
Depends on CatalaLang/catala#815