tests: fix macos test #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iMichka
force-pushed
the
macos-2
branch
12 times, most recently
from
42706c9 to
d2c71ac
Compare
Copilot
AI
left a comment
Copilot
AI
left a comment
There was a problem hiding this comment.
Copilot reviewed 5 out of 5 changed files in this pull request and generated 9 suggestions.
Comments skipped due to low confidence (3)
src/pygccxml/declarations/container_traits.py:75
- Changing the return value from cls_name to None may cause unintended behavior. Ensure this change is intentional and correctly handled by the calling code.
return None
src/pygccxml/declarations/container_traits.py:118
- Changing the return value from cls_name to None may cause unintended behavior. Ensure this change is intentional and correctly handled by the calling code.
result = templates.join(
.github/workflows/tests.yml:105
- Running only 'tests/test_remove_template_defaults.py' limits the test coverage to a single test file. Ensure all tests are run to maintain comprehensive test coverage.
pytest tests/test_remove_template_defaults.py
|
Rebased after #219, I think I have a clearer picture now on how to fix some tests now |
iMichka
force-pushed
the
macos-2
branch
2 times, most recently
from
84c0711 to
a51dd12
Compare
iMichka
force-pushed
the
macos-2
branch
11 times, most recently
from
005de99 to
835a5e2
Compare
iMichka
force-pushed
the
macos-2
branch
6 times, most recently
from
8165577 to
b38ed01
Compare
Fix string replacement (broken due to space mismatches)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.