Skip to content

Decklink consumer VANC #1642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Decklink consumer VANC #1642

wants to merge 6 commits into from

Conversation

niklaspandersson
Copy link
Member

Add support for adding VANC packets to decklink frames

  • Separate Vanc class that handles vanc related logic
  • Strategy based approach to isolate different types of ancilliary data
  • Only support for a push based workflow atm (via amcp APPLY, se separate PR amcp: add APPLY command, similar to CALL but for consumers #1638 ), but should be fairly easy to extend with support for data arriving from other sources (ie. the producer/consumer-pipeline)

@niklaspandersson niklaspandersson mentioned this pull request Jun 12, 2025
Open
@programmerjake programmerjake mentioned this pull request Jun 13, 2025
Draft
programmerjake
programmerjake reviewed Jun 13, 2025
View reviewed changes
programmerjake
programmerjake reviewed Jun 13, 2025
View reviewed changes
programmerjake
programmerjake reviewed Jun 13, 2025
View reviewed changes
programmerjake
programmerjake reviewed Jun 13, 2025
View reviewed changes
@niklaspandersson niklaspandersson force-pushed the feat/upstream-decklink-vanc branch from 8658119 to bdaafa9 Compare June 13, 2025 11:40
programmerjake
programmerjake reviewed Jun 13, 2025
View reviewed changes
programmerjake
programmerjake reviewed Jun 13, 2025
View reviewed changes
@niklaspandersson
chore: upgrade decklink sdk headers to version 12.3
e0692f0
@niklaspandersson
decklink: Add vanc utility class
f376456
@niklaspandersson
feat: Add scte-104 decklink vanc strategy
5ae9633 
* Adds scte-104 vanc packets to decklink frames based on pushed (amcp APPLY) data
@niklaspandersson
chore: Add base64 header to decklink module
3c79dc0
@niklaspandersson
feat: Add decklink support for vanc packets on both fields of interla…
1559bc7 
…ced frames
@niklaspandersson
feat: Add op47 decklink vanc strategy for subtitles
0768108 
* Adds op47 vanc packets to decklink frames based on pushed (amcp APPLY) data
* Support configuring base64 encoded dummy header for time filling
@niklaspandersson niklaspandersson force-pushed the feat/upstream-decklink-vanc branch from bdaafa9 to 0768108 Compare June 16, 2025 10:28
@niklaspandersson niklaspandersson marked this pull request as ready for review June 18, 2025 12:03
@TomKaltz
Copy link
Member

@niklaspandersson what's the status of this?

@programmerjake
Copy link
Contributor

I'm waiting on this to merge to update #1637 and get it ready for merging

@niklaspandersson
Copy link
Member Author

I'm fine with this as it is. I figured @Julusian would say something, but I take the silence as no objections.
I'll get the conflicts resolved so that we can merge it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
2 more reviewers

@dimitry-ishenko dimitry-ishenko dimitry-ishenko left review comments

@programmerjake programmerjake programmerjake left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@niklaspandersson @TomKaltz @programmerjake @dimitry-ishenko