fix(widgets): Include spatialDataColumn in widget requests unconditionally #183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since early on (see #34) the API client has included the
spatialDataColumnandspatialDataTypeparameters in Model API requests if and only if a spatial filter is active. However, I'm seeing table widget requests that include geometry (geom, h3, quadbin) in their list of requested columns receive different results depending on whether these parameters are present, even without a spatial filter. This causes E2E tests to fail.The C4R-based code currently in Builder includes both parameters, even without a spatial filter, so for the sake of backward compatibility I think it's safest to include
spatialDataColumnandspatialDataTypeunconditionally.PR Dependency Tree
This tree was auto-generated by Charcoal