-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CardDb: add normalized Names #4376
Conversation
@tehdiplomat what should i do with:
? |
@tehdiplomat @kevlahnota the Pattern in DeckRecognizer should probably be updated for Unicode |
The Font for Mobile doesn't need to be touched, because |
@tehdiplomat @kevlahnota i did some funky with the CardRulesPredicates when searching Cards in the Deck Editor, it now searches for all the faces. this helps when searching for cards like with Adventure and for Card names, it even support the normalized names. so when you search for "Lim-Dul" you get "Lim-Dûl" too |
b42d8c2
to
3e107b2
Compare
3e107b2
to
c3c9eca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As long as deck/quest loading can still handle normalized names I'm fine with the general idea of these changes. The next time they save they'll have the UTF names I guess?
This reverts commit ce9ca39.
This reverts commit ce9ca39.
This reverts commit b396f41.
This reverts commit b396f41.
closes #4365
The Deck import currently still can't understand the OG "û", i need to debug why