LCI - Craft implementation

[Northmoc]

• closes Craft mechanic #4098

[Northmoc]

This is all the Craft cards except #4167 now + Fabrication Foundry

Pretty sure AI would fail or cheat paying exile costs for Fabrication Foundry and Eye of Ojer Taq? Unsure if that should be another PR or if we add even more to this gargantuan. Perhaps quickest short-term solution is mark them both RemoveDeck:All?
@Agetian - as always your AI opinions are coveted here

[Agetian]

Nice job!
I would say test them in the AI's hands, and if anything is off, mark them with AI DeckRemove for now and make an issue, assign it to me. I'll try to make things work as a follow-up MR.

[tool4ever]

@Agetian
I think I cleaned AI up, please test if possible :)

[Northmoc]

@Agetian I think I cleaned AI up, please test if possible :)

AI Craft use seems the same so I think it was a good refactor

[Agetian]

Nice job, I'll test it soon! Thanks for help! 👍

[Agetian]

Hmm, got this crash from the following game state (attached). Supposedly when trying to activate Craft for Throne of the Grim Captain.

Game-0 > java.lang.NullPointerException
at forge.util.collect.FCollection.addAll(FCollection.java:310)
at forge.util.collect.FCollection.addAll(FCollection.java:296)
at forge.ai.ability.ChangeZoneAi.willPayCosts(ChangeZoneAi.java:65)
at forge.ai.SpellAbilityAi.canPlayWithoutRestrict(SpellAbilityAi.java:93)
at forge.ai.SpellAbilityAi.canPlayAI(SpellAbilityAi.java:54)
at forge.ai.SpellAbilityAi.canPlayAIWithSubs(SpellAbilityAi.java:37)
at forge.ai.AiController.canPlaySa(AiController.java:894)
at forge.ai.AiController.canPlayAndPayForFace(AiController.java:809)
at forge.ai.AiController.canPlayAndPayFor(AiController.java:759)
at forge.ai.AiController.chooseSpellAbilityToPlayFromList(AiController.java:1658)

craft_crash.txt

[Agetian]

It looks like a NPE guard is needed circa ChangeZoneAi.java:65:

                    CardCollection toAdd = ComputerUtil.chooseExileFrom(ai, (CostExile) part, source, amt, sa);
                    if (toAdd != null) {
                        payingCards.addAll(toAdd);
                    }

[Agetian]

Tested various other things, other stuff seems to work fine on my end :)

[tool4ever]

ok, I think it's pretty ready at this point 👍