fix shell command built from environment values #584
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cap/scripts/setup.js
Line 5 in b1094ab
Cap/scripts/setup.js
Line 111 in b1094ab
Fix the issue, the shell command should be refactored to avoid dynamic string construction and instead use
execFile
orexecFileSync
, which allows passing arguments separately to the command. This approach ensures that the paths are treated as literal arguments and not interpreted by the shell.Specifically:
exec
call on line 111 withexecFile
orexecFileSync
.tar
command and its arguments as separate parameters, ensuring thatffmpegZipPath
andtargetDir
are treated as literal values.