feat: add playback speed control and visualization for video segments #506
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@richiemcilroy @Brendonovich Can you Please take a look at this? |
|
Does this PR actually implement clip retiming or is it just the editor UI? |
|
Yes it implements the functionality and the editor UI changes |
|
Did you forget to push some code? You've made no changes to the Rust code in charge of playback or exporting that would be necessary to implement this |
|
Oh yes I had forgotten to push the backend changes |
|
Pushed the backend changes as well @Brendonovich. |
|
Could this be merged? |
|
This wasn't working for me and I needed speed editing soon so I added #632 but feel free to use this instead |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features Added
Motivation
I've been wanting this feature for so long that I decided to implement it myself! Cap has become an essential tool in my workflow, and the ability to speed up/slow down specific sections will make it even more powerful for creating polished videos.
I love this product and hope this contribution helps make it even better for everyone. Looking forward to your feedback!