Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): upgrade DataFusion to 46.0.0 #1084

Merged
merged 4 commits into from
Mar 11, 2025

Conversation

goldmedal
Copy link
Contributor

@goldmedal goldmedal commented Mar 10, 2025

Description

  • Upgrade DataFusion to 46.0.0

Known Issues

  • Expr::Wildcard is deprecated.
  • CountWildcardRule has been removed. It will lead to the generated SQL not being valid for BigQuery.

Summary by CodeRabbit

This release introduces several improvements that enhance stability and query reliability:

  • Chores
    • Switched to a stable dependency version for enhanced compatibility.
  • Refactor
    • Upgraded internal processing with enriched metadata tracking and streamlined logic.
  • Bug Fixes
    • Adjusted query formatting with proper identifier quoting and alias handling for consistent SQL execution.
    • Removed deprecated analyzer rule to simplify local runtime analysis.

These updates aim to deliver a smoother and more predictable experience when executing queries and managing data.

Copy link

coderabbitai bot commented Mar 10, 2025

Walkthrough

This PR updates the dependency resolution method for the datafusion library by switching from a branch-based Git reference to a version-based approach (46.0.0). It also incorporates a spans field into Column struct instantiations in core analysis and test modules, adds comments and #[allow(deprecated)] attributes to manage deprecated wildcard usage, adjusts import paths for DataFusion types, removes an analyzer rule, and refines SQL query strings and test identifiers.

Changes

File(s) Change Summary
wren-core/Cargo.toml Updated datafusion dependency from a Git branch reference to version "46.0.0".
wren-core/.../model_anlayze.rs, wren-core/.../lineage.rs Added spans field to Column struct in analysis methods and test assertions.
wren-core/.../plan.rs, wren-core/.../dialect/utils.rs, wren-core/.../utils.rs Added comments and #[allow(deprecated)] attributes to suppress warnings for deprecated wildcard usage.
wren-core/.../context.rs, wren-core/.../utils.rs Updated import paths for DataFusion types and removed CountWildcardRule from local analyzer rules.
wren-core/.../mod.rs Modified SQL queries to include double quotes around identifiers and adjusted aliasing for compliance.
wren-core/.../q22.slt.part Removed an outdated TODO comment with an error message and updated the query identifier from TIR to ?IR.
ibis-server/tests/conftest.py Updated constant DATAFUSION_FUNCTION_COUNT from 271 to 273.
wren-core-py/tests/test_modeling_core.py Adjusted assertions in test_read_function_list to reflect increased expected function counts.

Possibly related PRs

Suggested reviewers

  • wwwy3y3

Poem

I’m a rabbit in the code, hopping along the stream,
Upgraded dependencies, as neat as they may seem.
Columns now carry spans, tiny details in their wake,
Deprecated warnings silenced for cleaner paths to take.
SQL strings twinkle with quotes and precise design,
Coding in our burrow is simply so divine!
Hop on, fellow coder, let the improvements shine!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1f3ba20 and 9e8c80c.

📒 Files selected for processing (2)
  • ibis-server/tests/conftest.py (1 hunks)
  • wren-core-py/tests/test_modeling_core.py (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (8)
  • GitHub Check: cargo test (amd64)
  • GitHub Check: clippy
  • GitHub Check: check Cargo.toml formatting
  • GitHub Check: cargo test (win64)
  • GitHub Check: cargo test (macos)
  • GitHub Check: cargo test (macos-aarch64)
  • GitHub Check: ci
  • GitHub Check: test
🔇 Additional comments (3)
ibis-server/tests/conftest.py (1)

14-14: Function count updated to match DataFusion 46.0.0

The constant DATAFUSION_FUNCTION_COUNT has been correctly updated from 271 to 273, reflecting the two additional functions available in DataFusion 46.0.0. This keeps the test expectations aligned with the upgraded library version.

wren-core-py/tests/test_modeling_core.py (2)

109-109: Function count updated for custom functions path scenario

This assertion has been properly updated to expect 275 functions (up from 273) when a custom functions path is provided, reflecting the two additional functions available in DataFusion 46.0.0.


121-121: Function count updated for default scenario

This assertion has been properly updated to expect 273 functions (up from 271) when no custom functions path is provided, which correctly matches the updated DATAFUSION_FUNCTION_COUNT constant from the conftest.py file.

✨ Finishing Touches
  • 📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added core dependencies Pull requests that update a dependency file rust Pull requests that update Rust code python Pull requests that update Python code labels Mar 10, 2025
@github-actions github-actions bot added the ibis label Mar 10, 2025
@goldmedal goldmedal requested a review from douenergy March 10, 2025 03:05
@douenergy douenergy merged commit e1453e4 into Canner:main Mar 11, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core dependencies Pull requests that update a dependency file ibis python Pull requests that update Python code rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants