-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IRSA-6706, IRSA-6571: Add Image on background of Results tab #1724
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great.
Love seeing the images! Some comments/questions:
|
@vandesai1 answers:
|
@jaladh-singhal have you tried |
@loitly I did, it doesn't work as intended because we're using |
IRSA-6571: Add Euclid background image to landing page IRSA-6571: Add Spherex background image to landing page Edit webpack config to support .webp and to emit large images as files
IRSA-6571: Cleanup topSection logic in HydraApps Move icon from topSection to bottomSection IRSA-6571: Replace setIfUndefined with defaultsDeep for readability IRSA-6571: Separate defaultProps logic into functions
f39d1a5
to
527f8df
Compare
Fixes IRSA-6706, IRSA-6571
See ife PR: https://github.com/IPAC-SW/irsa-ife/pull/388
bgImage
is supplied by consumers (ife apps) and changes in LandingPage to support that.webp
files (SPHEREx image is available as webp) and to switch toasset/resource
for large files (background images are large, we don't want them inline)topSection
now acceptstitle
(to distinguish fromappTitle
), anddesc
that are used by Hydra appsicon
prop of HydraLanding is never used bytopSection
in any apps butbottomSection
uses it, so moved it there to avoid confusion and make it easier for consumers to define it (without going through slotProps route)setIfUndefined
withdefaultsDeep
since there are lot of slotProps modification, and having single nested object is more readable when overridingTesting
Check background image in landing page of:
Regression Testing in landing page of: