IRSA-6706, IRSA-6571: Add Image on background of Results tab#1724
Merged
jaladh-singhal merged 2 commits intodevfrom Mar 7, 2025
Merged
IRSA-6706, IRSA-6571: Add Image on background of Results tab#1724jaladh-singhal merged 2 commits intodevfrom
jaladh-singhal merged 2 commits intodevfrom
Conversation
robyww
approved these changes
Mar 7, 2025
loitly
reviewed
Mar 7, 2025
|
Love seeing the images! Some comments/questions:
|
Member
Author
@vandesai1 answers:
|
Contributor
@jaladh-singhal have you tried |
Member
Author
@loitly I did, it doesn't work as intended because we're using |
IRSA-6571: Add Euclid background image to landing page IRSA-6571: Add Spherex background image to landing page Edit webpack config to support .webp and to emit large images as files
IRSA-6571: Cleanup topSection logic in HydraApps Move icon from topSection to bottomSection IRSA-6571: Replace setIfUndefined with defaultsDeep for readability IRSA-6571: Separate defaultProps logic into functions
f39d1a5 to
527f8df
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes IRSA-6706, IRSA-6571
See ife PR: https://github.com/IPAC-SW/irsa-ife/pull/388
bgImageis supplied by consumers (ife apps) and changes in LandingPage to support that.webpfiles (SPHEREx image is available as webp) and to switch toasset/resourcefor large files (background images are large, we don't want them inline)topSectionnow acceptstitle(to distinguish fromappTitle), anddescthat are used by Hydra appsiconprop of HydraLanding is never used bytopSectionin any apps butbottomSectionuses it, so moved it there to avoid confusion and make it easier for consumers to define it (without going through slotProps route)setIfUndefinedwithdefaultsDeepsince there are lot of slotProps modification, and having single nested object is more readable when overridingTesting
Check background image in landing page of:
Regression Testing in landing page of: