Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added documentation for Caliburn Micro project template #46

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Aixtreme-Agile
Copy link

Documentation explains how to install Visual Studio Extensions that provides Caliburn Micro WPF project templates and how to use the project template.

Documentation explains how to install Visual Studio Extensions that provides Caliburn Micro WPF project templates and how to use the project template.
@vb2ae
Copy link
Member

vb2ae commented Nov 7, 2021

Two requests for this PR. First please do not check in the .vs folder. Second could you add the following line to the .gitignore file

.vs/

@Aixtreme-Agile
Copy link
Author

hi @vb2ae , I have added the .vs in .gitignore (see screenshot below). But I don't know how to "not check in .vs". Frankly said I am quite new in Git and I use only default setting after forking. Please tell me how to do it, I will check into the correct folder. Thx

github_desktop

@vb2ae
Copy link
Member

vb2ae commented Nov 10, 2021

@Aixtreme-Agile When looking at file changed tab. if you press the 3 dots on the right for the files in the .vs folder it should give the option to delete the files.

image

@Aixtreme-Agile
Copy link
Author

@vb2ae unfortunately I have no rights to delete. Please see following screenshot.
CannotDelete

@vb2ae
Copy link
Member

vb2ae commented Nov 11, 2021

Ok I deleted the files. I will do one final review this weekend

@KasperSK
Copy link
Member

Should we move the link to a new section in index.md so that we illustrate that the templates are not maintained by Caliburn Micro? I know you made some templates also @vb2ae but they where not port of the CM repo where they?

@Aixtreme-Agile
Copy link
Author

@KasperSK sorry for asking: do you ask me? I think, that should @vb2ae decide, if the documentation about template is separated or not. I am still quite new in this community, but I have used CM since 2015 and still use it. This PR is my very first PR here. My CM project templates is uploaded to Marketplace.

@KasperSK
Copy link
Member

@Aixtreme-Agile Yes I am co maintaining with @vb2ae so it was a question for him. I just wanted to make sure that users of the templates knew that we do not maintain them in the CM project.

@vb2ae
Copy link
Member

vb2ae commented Nov 26, 2021

@KasperSK putting the templates on a new section is a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants