Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for maui #923

Merged
merged 17 commits into from
Dec 12, 2024
Merged

Add tests for maui #923

merged 17 commits into from
Dec 12, 2024

Conversation

vb2ae
Copy link
Member

@vb2ae vb2ae commented Nov 5, 2024

This pull request introduces a suite of unit tests for the Caliburn.Micro.Maui project and updates the project configuration. The changes include adding new test classes, updating the project file to include necessary packages and settings, and modifying access levels in the ActionMessage class.

Unit Tests Addition:

  • ActionMessageTests: Added tests to verify the MethodName, Handler, and Parameters properties of ActionMessage. (src/Caliburn.Micro.Maui.Tests/ActionMessageTests.cs)
  • AssemblyCacheTests: Added tests to ensure adding the same assembly multiple times and resetting the cache does not throw exceptions. (src/Caliburn.Micro.Maui.Tests/AssemblyCacheTests.cs)
  • FormsPlatformProviderTests: Added tests to verify the behavior of FormsPlatformProvider methods. (src/Caliburn.Micro.Maui.Tests/FormsPlatformProviderTests.cs)

Project Configuration:

  • Caliburn.Micro.Maui.Tests.csproj: Created a new test project file with references to necessary packages and project dependencies. (src/Caliburn.Micro.Maui.Tests/Caliburn.Micro.Maui.Tests.csproj)
  • Caliburn.Micro.Maui.csproj: Updated the language version to 10.0 and added an InternalsVisibleTo attribute for the test project. (src/Caliburn.Micro.Maui/Caliburn.Micro.Maui.csproj) [1] [2]

Codebase Changes:

  • ActionMessage.cs: Changed the access level of the Handler property setter from private to internal. (src/Caliburn.Micro.Platform/Platforms/Maui/ActionMessage.cs)

These changes collectively enhance the test coverage for the Caliburn.Micro.Maui project and ensure that the project is configured correctly for testing.

Closes #877

@vb2ae vb2ae linked an issue Nov 5, 2024 that may be closed by this pull request
@vb2ae vb2ae requested a review from KasperSK November 29, 2024 23:02
@vb2ae vb2ae requested a review from nigel-sampson December 5, 2024 12:17
@vb2ae vb2ae requested a review from Copilot December 12, 2024 13:06

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 17 changed files in this pull request and generated no suggestions.

Files not reviewed (11)
  • src/Caliburn.Micro.Maui.Tests/Caliburn.Micro.Maui.Tests.csproj: Language not supported
  • src/Caliburn.Micro.Maui/Caliburn.Micro.Maui.csproj: Language not supported
  • src/Caliburn.Micro.sln: Language not supported
  • src/Caliburn.Micro.Maui.Tests/AssemblyCacheTests.cs: Evaluated as low risk
  • src/Caliburn.Micro.Maui.Tests/FormsPlatformProviderTests.cs: Evaluated as low risk
  • src/Caliburn.Micro.Maui.Tests/ActionMessageTests.cs: Evaluated as low risk
  • src/Caliburn.Micro.Platform/Platforms/Maui/Parameter.cs: Evaluated as low risk
  • src/Caliburn.Micro.Platform/Platforms/Maui/ActionMessage.cs: Evaluated as low risk
  • src/Caliburn.Micro.Platform.Tests/ViewModelLocatorTests.cs: Evaluated as low risk
  • src/Caliburn.Micro.Platform.Tests/ViewLocatorTests.cs: Evaluated as low risk
  • src/Caliburn.Micro.Maui.Tests/ViewLocatorTests.cs: Evaluated as low risk
@vb2ae vb2ae merged commit 020e981 into master Dec 12, 2024
5 checks passed
@vb2ae vb2ae deleted the 877-update-unit-tests branch December 12, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Maui unit tests
1 participant