Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assembly hierarchy - 2nd take #545

Merged
merged 3 commits into from
Dec 18, 2020
Merged

Assembly hierarchy - 2nd take #545

merged 3 commits into from
Dec 18, 2020

Conversation

adam-urbanczyk
Copy link
Member

@adam-urbanczyk adam-urbanczyk commented Dec 13, 2020

This PR solves nested assembly naming and enforces unique names on a single assembly level.

@adam-urbanczyk
Copy link
Member Author

CC: @bernhard-42

@codecov
Copy link

codecov bot commented Dec 13, 2020

Codecov Report

Merging #545 (f2c6717) into master (ac585b4) will increase coverage by 0.14%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #545      +/-   ##
==========================================
+ Coverage   94.15%   94.30%   +0.14%     
==========================================
  Files          29       29              
  Lines        6189     6334     +145     
  Branches      655      670      +15     
==========================================
+ Hits         5827     5973     +146     
  Misses        224      224              
+ Partials      138      137       -1     
Impacted Files Coverage Δ
cadquery/assembly.py 90.45% <100.00%> (+0.45%) ⬆️
tests/test_assembly.py 100.00% <100.00%> (ø)
tests/test_selectors.py 100.00% <0.00%> (ø)
cadquery/cq.py 89.65% <0.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac585b4...f2c6717. Read the comment docs.

@jmwright
Copy link
Member

Looks ok to me. Thanks.

@adam-urbanczyk
Copy link
Member Author

@bernhard-42 do you agree with merging this for now? Based on the discussion in #543 you have some design choices to be made that might take some time.

@bernhard-42
Copy link
Contributor

@adam-urbanczyk fine for me. I do have a plan forward. Thanks for adding the hierarchies and the __classes__ thing

@adam-urbanczyk
Copy link
Member Author

OK, I'll merge tomorrow.

@adam-urbanczyk adam-urbanczyk merged commit 82a043a into master Dec 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants