Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for closed path fillet to Wire.fillet() #1573

Merged
merged 9 commits into from
Jun 13, 2024

Conversation

dov
Copy link
Contributor

@dov dov commented Apr 27, 2024

This PR adds support for fillet of a closed wire to the Wire.fillet() method, by adding a fillet arc between the last and the first segments

Copy link

codecov bot commented Apr 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.86%. Comparing base (f29f2d6) to head (d7b07a2).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1573   +/-   ##
=======================================
  Coverage   94.86%   94.86%           
=======================================
  Files          28       28           
  Lines        6226     6231    +5     
  Branches     1261     1264    +3     
=======================================
+ Hits         5906     5911    +5     
  Misses        193      193           
  Partials      127      127           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@adam-urbanczyk adam-urbanczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@adam-urbanczyk
Copy link
Member

@jmwright will you take a look? I had to replace some uses of typing_extensions.Literal with typing.Literal because of a unrelated osx failure. I do not fully understand why, but in general it is a change for better.

Copy link
Member

@jmwright jmwright left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to merge

@adam-urbanczyk adam-urbanczyk merged commit 33f72d2 into CadQuery:master Jun 13, 2024
5 checks passed
@adam-urbanczyk
Copy link
Member

Thanks @dov !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants