[codex] Update jQuery UI and theme assets#7082
Draft
somethingwithproof wants to merge 3 commits into
Draft
Conversation
Contributor
Author
|
Heads up: this drops the explicit |
Signed-off-by: Thomas Vincent <thomasvincent@gmail.com>
Member
|
@somethingwithproof is this still WIP? It appears from your comment that this might be a breaking change for things like tree view if say for example draggable is gone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
jquery-ui.cssfile on the 1.14.2 shared structure while preserving each theme's existing ThemeRoller colors and shadow settings.buttonset()calls withcontrolgroup()now that jQuery UI 1.14.2 no longer enables the backcompat path by default.controlgroup()path.Notes
Testing
node --check include/js/jquery-ui.jsnode --check include/layout.jsnode --check include/themes/dark/main.jsnode --check include/themes/modern/main.jsnode --check tests/e2e/jquery-smoke.spec.jsgit diff --checkrgchecks for stale jQuery UI versions, deprecatedbuttonset()calls, and old IE-only CSS compatibility linesNot run locally:
npx --no-install playwright test tests/e2e/jquery-smoke.spec.jscould not run because Playwright is not installed in this worktree;npx --no-installattempted npm registry access and failed under restricted network.