Skip to content

Commit

Permalink
Merge pull request #123 from ozanerturk/master
Browse files Browse the repository at this point in the history
  • Loading branch information
CacheControl authored Apr 23, 2019
2 parents 5ac00ea + 1e875d9 commit fa84a83
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 0 deletions.
1 change: 1 addition & 0 deletions src/engine.js
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,7 @@ class Engine extends EventEmitter {

let index = this.rules.indexOf(rule)
if (index === -1) return false
this.prioritizedRules = null
return Boolean(this.rules.splice(index, 1).length)
}

Expand Down
9 changes: 9 additions & 0 deletions test/engine.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@ describe('Engine', () => {
expect(engine.rules.length).to.equal(1)
engine.removeRule(rule)
expect(engine.rules.length).to.equal(0)
expect(engine.prioritizedRules).to.equal(null)
})
})

Expand All @@ -106,6 +107,14 @@ describe('Engine', () => {
const isRemoved = engine.removeRule(rule)
expect(isRemoved).to.equal(false)
})

it('clears the "prioritizedRules" cache', () => {
let rule = new Rule(factories.rule())
engine.addRule(rule)
engine.prioritizeRules()
engine.removeRule(rule)
expect(engine.prioritizedRules).to.equal(null)
})
})

describe('addOperator()', () => {
Expand Down

0 comments on commit fa84a83

Please sign in to comment.