-
Notifications
You must be signed in to change notification settings - Fork 86
Refactored CI infrastructure. #170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Co-authored-by: lohenry-escience <[email protected]>
Co-authored-by: lohenry-escience <[email protected]>
shell: bash | ||
run: | | ||
echo "INFO: Installing compiling environment: ${{ inputs.compiler }}" | ||
chmod a+x ./.github/actions/build/scripts/install-${{ inputs.compiler }}.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you prefer putting the test-related scripts in the .github repository, rather than in a dedicated scripts/testing directory which may be more accessible to people that could use them as reference? I do not have a strong feeling.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes... My logic is that the user who runs the test locally will run it in their own already set environment, which is
not necessarily the same as that is used on the CI. In that sense, the set-up of the environment is CI-specific.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@loostrum, to follow up on a query over Zulip, do you have an opinion about this? Thanks!
ed1397b
to
771960f
Compare
Co-authored-by: lohenry-escience <[email protected]>
This PR features a major change in the CI testing infrastructure, designed by Louis Henry @lohenry-escience in the framework of the ExaFLOW project.
The new infrastructure: