[CBRD-26010] Fix backup hang with different max_clients settings in [common] and [@db] sections in conf file #6102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
H2SU
approved these changes
Apr 9, 2025
hornetmj
reviewed
Apr 9, 2025
| @@ -1117,7 +1117,7 @@ net_server_start (const char *server_name) | |||
| goto end; | |||
| } | |||
|
|
|||
| sysprm_load_and_init (NULL, NULL, SYSPRM_LOAD_ALL); | |||
| sysprm_load_and_init (server_name, NULL, SYSPRM_LOAD_ALL); | |||
There was a problem hiding this comment.
net_server_start() -> boot_restart_server() 호출을 통해 sysprm_load_and_init()는 총 3번 호출되어 집니다. 다음 정보가 추가로 제공되어야 하겠습니다.
- net_server_start()에서 수정한 이유
- 수정 후 나머지 sysprm_load_and_init()를 그대로 둔 이유
- 불필요해서 제거될 수 있는 것은 없는지 여부가 검토되었는지 여부
There was a problem hiding this comment.
- 서버가 시작되고 처음 실행되는 sysprm_load_and_init()에서 server_name이 전달되어야 core의 개수를 설정할 때 [@db] 섹션 값까지 참조되게 됩니다.
- 서버가 시작되고 net_server_start() 함수에서 sysprm_load_and_init() 함수가 처음 호출됩니다.
- 나머지 sysprm_load_and_init() 함수에서도 db_name을 전달하도록 수정하였습니다.
- db_name이 전달되어야 [@db] 섹션 값까지 참조하기 때문에 해당 PR 과정에서 호출되는 모든 sysprm_load_and_init() 함수에는 db_name이 전달되는 것이 맞습니다.
- 3번의 호출 중 불필요한 것은 없습니다.
InChiJun
changed the title
H2SU
approved these changes
Apr 10, 2025
youngjun9072
approved these changes
Apr 10, 2025
hyahong
approved these changes
Apr 10, 2025
beyondykk9
approved these changes
Apr 10, 2025
hornetmj
reviewed
Apr 11, 2025
| @@ -2104,7 +2104,7 @@ boot_restart_server (THREAD_ENTRY * thread_p, bool print_restart, const char *db | |||
| } | |||
|
|
|||
| #if defined(SERVER_MODE) | |||
| if (sysprm_load_and_init (NULL, NULL, SYSPRM_LOAD_ALL) != NO_ERROR) | |||
| if (sysprm_load_and_init (db_name, NULL, SYSPRM_LOAD_ALL) != NO_ERROR) | |||
There was a problem hiding this comment.
앞선 질문에 이여서 질문드립니다. '3. 3번의 호출 중 불필요한 것은 없습니다.' 없다고 답변해 주셨는데, 아래에서 호출되는 sysprm_load_and_init (boot_Db_full_name, NULL, SYSPRM_LOAD_ALL)가 호출되어야 하는 이유가 있나요?
There was a problem hiding this comment.
sysprm_load_and_init (boot_Db_full_name, NULL, SYSPRM_LOAD_ALL) 에서의 호출은 중복 호출이기 때문에 필요 없는 호출입니다.
삭제하여 반영하겠습니다.
hornetmj
approved these changes
Apr 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://jira.cubrid.org/browse/CBRD-26010
Purpose
Implementation
Remarks
N/A