Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: emotion best practices and widget container stacking context #421

Merged
merged 1 commit into from
Feb 14, 2025

Conversation

Charlie-XIAO
Copy link
Contributor

@Charlie-XIAO Charlie-XIAO commented Feb 13, 2025

Extracted from and refactored upon #370.

The changes are mostly based on emotion best practices. In particular, define styles outside of components, and use the style prop for dynamic styles.

Another change is to the widget container, which avoid using zIndex: 9999 but rely on relative stacking context (with an additional wrapper layer) to make sure the handle stays above the component.

@Charlie-XIAO Charlie-XIAO changed the title refactor: css as const and styles for dynamic refactor: emotion best practices and widget container stacking context Feb 13, 2025
@Charlie-XIAO Charlie-XIAO merged commit 0bd6d0c into main Feb 14, 2025
11 checks passed
@Charlie-XIAO Charlie-XIAO deleted the refactor/styling branch February 14, 2025 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant