refactor: slightly more accessible and consistent number input #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Radix UI does not have a number field component, which is pretty sad. Relying on some external component library (or even their hook) would probably be too heavy and overkill. This PR just added some accessibility to the
<input type="number">thing (note: it did not change totype="text"andinputMode="numeric", because thoughtype="number"is a little bit inconsistent in validation, its default snappers can reduce a lot of our work, so at least I kept it for now).New behaviors:
Other behaviors are the same as before, but again hardcoded instead of using the default behavior which could be inconsistent across browsers. This also has better validation (to tackle inconsistency problems) and better clamp & snap behavior.