refactor: reorganize top level widgets tab #406
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from and refactored upon #370. This PR mainly does the following:
components
directory withindex.tsx
being the tab component itself and other files being relevant building blocks.Widgets
tab care only about IDs. The building blocksTrigger
,Config
andSettings
are memoized and care about only one of config and settings of specific widget as they need. They are memoized as well.Record<string, { config: WidgetConfig, settings: WidgetSettings }
instead of{ id: string, config: WidgetConfig, settings: WidgetSettings }[]
. This is so that we can access each widget by ID (which is reliable) instead of by index (not sure if there will be issues). If by ID but using array, we would either need to make parents pass stuff down which can cause unnecessary rerendering in parents, or we would need to usefind
which seems not performant. Switching back toRecord
we can still ensure sortedness by creating object from sorted entries.Future work include:
Trigger
,Config
, andSettings
.