Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: events/commands/types restructured #403

Merged
merged 2 commits into from
Feb 3, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/canvas/components/WidgetContainer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import {
updateWidgetSettings,
useWidgetsStore,
} from "../hooks/useWidgetsStore";
import { emitUpdateSettingsToManager } from "../../events";
import { events } from "../../core";

interface WidgetContainerProps {
id: string;
Expand All @@ -25,7 +25,7 @@ const WidgetContainer = memo(({ id }: WidgetContainerProps) => {
(_: DraggableEvent, data: DraggableData) => {
const pos = { x: x + data.x, y: y + data.y };
updateWidgetSettings(id, pos);
emitUpdateSettingsToManager({ id, settings: pos });
events.updateSettings.toManager({ id, settings: pos });
},
[id, x, y],
);
Expand Down
4 changes: 2 additions & 2 deletions src/canvas/hooks/useRemoveWidgetsListener.tsx
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import { useEffect } from "react";
import { listenToRemoveWidgets } from "../../events";
import { events } from "../../core";
import { removeWidgets } from "./useWidgetsStore";

export function useRemoveWidgetsListener() {
useEffect(() => {
const unlisten = listenToRemoveWidgets((event) => {
const unlisten = events.removeWidgets.on((event) => {
removeWidgets(event.payload.ids);
});

Expand Down
10 changes: 5 additions & 5 deletions src/canvas/hooks/useRenderWidgetsListener.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { useEffect, useRef } from "react";
import { listenToRenderWidgets } from "../../events";
import { invokeBundleWidget, invokeSetRenderReady } from "../../commands";
import { commands, events } from "../../core";
import {
updateWidgetRender,
updateWidgetRenderError,
Expand All @@ -15,7 +14,7 @@ export function useRenderWidgetsListener() {
const hasInited = useRef(false);

useEffect(() => {
const unlisten = listenToRenderWidgets(async (event) => {
const unlisten = events.renderWidgets.on(async (event) => {
const widgets = useWidgetsStore.getState().widgets;

const promises = event.payload.map(async ({ id, settings, code }) => {
Expand All @@ -42,7 +41,7 @@ export function useRenderWidgetsListener() {
if (code === undefined) {
// If code is not provided, we need to bundle the widget
try {
code = await invokeBundleWidget({
code = await commands.bundleWidget({
id,
baseUrl: BASE_URL,
apisBlobUrl,
Expand Down Expand Up @@ -93,7 +92,8 @@ export function useRenderWidgetsListener() {

if (!hasInited.current) {
// Set the canvas as ready to render only once
invokeSetRenderReady()
commands
.setRenderReady()
.then(() => {
hasInited.current = true;
})
Expand Down
9 changes: 4 additions & 5 deletions src/canvas/hooks/useShowToastListener.tsx
Original file line number Diff line number Diff line change
@@ -1,17 +1,16 @@
import { useEffect } from "react";
import { listenToShowToast } from "../../events";
import { events } from "../../core";
import { toast } from "sonner";
import { ShowToastPayloadType } from "../../types/backend";

export function useShowToastListener() {
useEffect(() => {
const unlisten = listenToShowToast((event) => {
const unlisten = events.showToast.on((event) => {
const { type, content } = event.payload;
switch (type) {
case ShowToastPayloadType.SUCCESS:
case events.ShowToastPayloadType.SUCCESS:
void toast.success(content);
break;
case ShowToastPayloadType.ERROR:
case events.ShowToastPayloadType.ERROR:
void toast.error(content);
break;
}
Expand Down
4 changes: 2 additions & 2 deletions src/canvas/hooks/useTheme.ts
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
import { useEffect, useState } from "react";
import { listenToSwitchTheme } from "../../events";
import { events } from "../../core";

export function useTheme() {
const [theme, setTheme] = useState(
window.__DESKULPT_CANVAS_INTERNALS__.initialSettings.app.theme,
);

useEffect(() => {
const unlisten = listenToSwitchTheme((event) => {
const unlisten = events.switchTheme.on((event) => {
setTheme(event.payload.theme);
});

Expand Down
4 changes: 2 additions & 2 deletions src/canvas/hooks/useUpdateSettingsListener.ts
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import { useEffect } from "react";
import { listenToUpdateSettings } from "../../events";
import { events } from "../../core";
import { updateWidgetSettings } from "./useWidgetsStore";

export function useUpdateSettingsListener() {
useEffect(() => {
const unlisten = listenToUpdateSettings((event) => {
const unlisten = events.updateSettings.on((event) => {
const { id, settings } = event.payload;
updateWidgetSettings(id, settings);
});
Expand Down
2 changes: 1 addition & 1 deletion src/canvas/hooks/useWidgetsStore.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { create } from "zustand";
import { WidgetSettings } from "../../types/backend";
import { WidgetSettings } from "../../types";
import { FC, createElement } from "react";
import ErrorDisplay from "../components/ErrorDisplay";

Expand Down
3 changes: 1 addition & 2 deletions src/canvas/main.tsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { StrictMode } from "react";
import { createRoot } from "react-dom/client";
import { DeepReadonly } from "../types/frontend";
import { Settings } from "../types/backend";
import { DeepReadonly, Settings } from "../types";
import App from "./App";
import "@radix-ui/themes/styles.css";

Expand Down
69 changes: 0 additions & 69 deletions src/commands.ts

This file was deleted.

29 changes: 29 additions & 0 deletions src/core/commands.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
import { invoke } from "@tauri-apps/api/core";
import { Settings, Shortcuts, WidgetConfig } from "../types";
import { RenderWidgetsPayload } from "./events";

export const bundleWidget = (payload: {
id: string;
baseUrl: string;
apisBlobUrl: string;
}) => invoke<string>("bundle_widget", payload);

export const emitOnRenderReady = (payload: { payload: RenderWidgetsPayload }) =>
invoke<void>("emit_on_render_ready", payload);

export const exitApp = (payload: { settings: Settings }) =>
invoke<void>("exit_app", payload);

export const openInWidgetsDir = (payload: { components: string[] }) =>
invoke<void>("open_in_widgets_dir", payload);

export const rescanWidgets = () =>
invoke<Record<string, WidgetConfig>>("rescan_widgets");

export const setRenderReady = () => invoke<void>("set_render_ready");

export const updateShortcut = (payload: {
key: keyof Shortcuts;
oldShortcut: string | null;
newShortcut: string | null;
}) => invoke<void>("update_shortcut", payload);
93 changes: 93 additions & 0 deletions src/core/events.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,93 @@
import { EventCallback, emitTo, listen } from "@tauri-apps/api/event";
import { Theme, WidgetSettings } from "../types";

// -----------------------------------------------------------------------------
// Backend => "exit-app" => Manager
// -----------------------------------------------------------------------------

export const exitApp = {
on: (handler: EventCallback<void>) => listen("exit-app", handler),
};

// -----------------------------------------------------------------------------
// Manager => "remove-widgets" => Canvas
// -----------------------------------------------------------------------------

interface RemoveWidgetsPayload {
ids: string[];
}

export const removeWidgets = {
on: (handler: EventCallback<RemoveWidgetsPayload>) =>
listen("remove-widgets", handler),
toCanvas: (payload: RemoveWidgetsPayload) =>
emitTo("canvas", "remove-widgets", payload),
};

// -----------------------------------------------------------------------------
// Manager => "render-widgets" => Canvas
// -----------------------------------------------------------------------------

export type RenderWidgetsPayload = {
id: string;
settings?: any;
code?: string;
}[];

export const renderWidgets = {
on: (handler: EventCallback<RenderWidgetsPayload>) =>
listen("render-widgets", handler),
toCanvas: (payload: RenderWidgetsPayload) =>
emitTo("canvas", "render-widgets", payload),
};

// -----------------------------------------------------------------------------
// Backend => "show-toast" => Manager
// -----------------------------------------------------------------------------

export enum ShowToastPayloadType {
SUCCESS = "SUCCESS",
ERROR = "ERROR",
}

type Payload =
| { type: ShowToastPayloadType.SUCCESS; content: string }
| { type: ShowToastPayloadType.ERROR; content: string };

export const showToast = {
on: (handler: EventCallback<Payload>) => listen("show-toast", handler),
};

// -----------------------------------------------------------------------------
// Manager => "switch-theme" => Canvas
// -----------------------------------------------------------------------------

interface SwitchThemePayload {
theme: Theme;
}

export const switchTheme = {
on: (handler: EventCallback<SwitchThemePayload>) =>
listen("switch-theme", handler),
toCanvas: (payload: SwitchThemePayload) =>
emitTo("canvas", "switch-theme", payload),
};

// -----------------------------------------------------------------------------
// Manager => "update-settings" => Canvas
// Canvas => "update-settings" => Manager
// -----------------------------------------------------------------------------

interface UpdateSettingsPayload {
id: string;
settings: Partial<WidgetSettings>;
}

export const updateSettings = {
on: (handler: EventCallback<UpdateSettingsPayload>) =>
listen("update-settings", handler),
toCanvas: (payload: UpdateSettingsPayload) =>
emitTo("canvas", "update-settings", payload),
toManager: (payload: UpdateSettingsPayload) =>
emitTo("manager", "update-settings", payload),
};
2 changes: 2 additions & 0 deletions src/core/index.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
export * as commands from "./commands";
export * as events from "./events";
Loading