New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: better error display and other minor adjustments #402

Merged

Charlie-XIAO merged 1 commit into main from refactor/error-display

Feb 3, 2025

Contributor

Charlie-XIAO commented Feb 3, 2025

Use a Dialog modal for the displaying widget error so that it is easier to view.
Remove JSDoc. Use just normal comments to explain logic. We are already using TypeScript so we do not need JSDoc for type hints, and we are not library to be consumed by people.
Make ShowToastPayload SCREAMING_SNAKE_CASE because it is an enum and it has no good reason to opt-out the rule of SCREAMING_SNAKE_CASE for enum, camelCase for struct.


          refactor: better error display and other minor adjustments

326337b

Charlie-XIAO merged commit 59e59ec into main

11 checks passed

Charlie-XIAO deleted the refactor/error-display branch

February 3, 2025 19:47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet