chore: serde rename to camel case unless in rare cases #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #370.
The concensus is: enum variants are SCREAMING_SNAKE_CASE and others are camelCase. On in special cases can this rule be broken, e.g.
Themeis easier to work with in lowercase (rather than SCREAMING_SNAKE_CASE) because some component libraries take thethemeprop as"light" | "dark". Note that we put#[serde(rename_all = "camelCase")]even in cases where this does not have any effect (i.e., when it is only one word). This is for consistency considerations, and in case if we changed the naming or added more props in the future things automatically works.