FIX ReactDOM.findDOMNode() is deprecated caused by Draggable
#38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I didn't encounter this bug on Windows 11. |
ROMEEZHOU
reviewed
Apr 19, 2024
rz2606
reviewed
Apr 19, 2024
There was a problem hiding this comment.
I didn't encounter this warning on Windows 11. These changes seem to address the deprecation warning caused by Draggable in React.StrictMode by properly setting up the nodeRef for Draggable and referencing it in the container component. Overall, it looks good！
rz2606
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we wrap in
React.StrictModein dev mode for debugging,Draggablecauses a deprecation warning as described in the title with the latest version ofReactthat we are using. The PR implemented the fix mentioned in the changelog ofDraggable.