Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH make widget <div> draggable #31

Merged
merged 3 commits into from
Apr 16, 2024
Merged

Conversation

rz2606
Copy link
Contributor

@rz2606 rz2606 commented Apr 14, 2024

An updated version of #27 to make div draggable.
(Import Draggable component from the "react-draggable" package)

Copy link
Contributor

@Charlie-XIAO Charlie-XIAO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rz2606, this one looks nicer! I've let some minor comments. LGTM once those are resolved :)

src/components/WidgetContainer/index.tsx Show resolved Hide resolved
src/components/WidgetContainer/index.tsx Outdated Show resolved Hide resolved
src/components/WidgetContainer/index.tsx Outdated Show resolved Hide resolved
@Charlie-XIAO Charlie-XIAO changed the title [updated] make div draggable ENH make widget <div> draggable Apr 14, 2024
@Charlie-XIAO Charlie-XIAO added the type:enhancement New feature or request label Apr 14, 2024
Copy link
Contributor

@Charlie-XIAO Charlie-XIAO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pushed the suggestions. Merging on CI green.

@Charlie-XIAO Charlie-XIAO merged commit e1f8737 into main Apr 16, 2024
6 checks passed
@Charlie-XIAO Charlie-XIAO deleted the widget_draggable_updated branch April 16, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants