Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST remove unnecessary exact checks from bundler tests #217

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

Charlie-XIAO
Copy link
Contributor

@Charlie-XIAO Charlie-XIAO commented Aug 29, 2024

This PR mainly makes the following changes:

  • Removed external_deps and converted part of it into default_deps. The part specifically for external dependencies will be covered in ENH support external dependencies in widget development #66 where the new behavior is implemented.
  • Combine replace_apis into default_deps because @deskulpt-test/apis is also a default dependency and the complexity clearly allows to use one test for both of them.
  • Skip most error messages in the error chain that does not include useful information, such as load_transformed failed.
  • Use regex for error messages that include paths, URLs, etc. This is mainly to reduce complexity.
  • Improve output of assert_err_eq a bit to provide more information of what we actually got

import osName from "https://cdn.jsdelivr.net/npm/[email protected]/+esm";
import osName from "https://foo.js";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have changed to use regex, so that the + character in the original URL causes problem (well we can just escape that but let's make things simpler).

Copy link

github-actions bot commented Aug 29, 2024

✔️ Deskulpt Built Successfully!

Deskulpt binaries have been built successfully on all supported platforms. Your pull request is in excellent shape! You may check the built Deskulpt binaries here and download them to test locally.

Workflow file: .github/workflows/build.yaml. Generated for commit: e07d4dc.

@Charlie-XIAO Charlie-XIAO merged commit e227699 into main Aug 29, 2024
11 checks passed
@Charlie-XIAO Charlie-XIAO deleted the relax-bundler-tests branch August 29, 2024 15:29
@Charlie-XIAO Charlie-XIAO added the type:testing Improvement of test suite label Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:testing Improvement of test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant