Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The search dialog core functionality is moved into a separate class.
Added unit tests for the class. Without this change I do not believe it is possible to make any "reliable" improvements for the search.
The unit tests are so far run only locally. CI adjustments can be done later if this PR is merged
The "payload range" functionality is not implemented: it does not work in the
master
-branch and requirements are unclear.Since in this PR I use
optional
andvariant
I also switch on c++17 standard where these utils were introduced. If not acceptable, in principle code can be rewritten without them. See #501I tested the refactored search functionality on several dlt file manually, so far I did not see issues.