API Forward additional kwargs from sensitivity plot to matplotlib #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes CORE-GATECH-GROUP#423 Default drawstyle is steps-post Related to - CORE-GATECH-GROUP#433 - relying on `drawstyle` over `steps` - CORE-GATECH-GROUP#417 - passing more kwargs to matplotlib plot routines
By converting to a set, the ordering of the perturbations, like zai=["total", 922380] was not guarunteed to be consistent.
drewejohnson
added
API - Compatible
DanKotlyar
approved these changes
Mar 22, 2021
Signed-off-by: Andrew Johnson <[email protected]>
drewejohnson
force-pushed
the
423-sens-plot-args
branch
from
21b7f7d to
f4bc279
Compare
Should enable the ability to examine the plots generated in testing Signed-off-by: Andrew Johnson <[email protected]>
drewejohnson
force-pushed
the
423-sens-plot-args
branch
from
f4bc279 to
e883b1c
Compare
The legend takes up ~80% of the image and can be very difficult to test. Small differences in font libraries seem to be most problematic Signed-off-by: Andrew Johnson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #423 by allowing a
**kwargsargument to be passed directly to matplotlib. Some disclaimerslabelandlabelFmtare not allowed to be passed at the same time, since they do competing thingsdrawstyleargument issteps-postlike the previousstepsmode - DEP Deprecate steps plot argument in favor of matplotlib drawstyle #433Related to meta-issue #417