Completed-All-TASKS!!! #6
Conversation
middlewares/no_auth_required.js
Outdated
| export function Authorized(token){ | ||
| if (token) { | ||
| console.log("Welcome Back!"); |
There was a problem hiding this comment.
You should have redirected the already logged In user to the index page
There was a problem hiding this comment.
I redirected user to homepage now by changing auth_required.js and no_auth_required.js. Please, review now!
There was a problem hiding this comment.
Sorry for the delay in making changes due to endsems.
components/LoginForm.js
Outdated
| const { login,API_BASE_URL,setpagetype } = useAuth() | ||
| useEffect(()=>{setpagetype("LOGIN");return;},[]) | ||
| const loginnow = () => { | ||
| const user_name = document.getElementById("inputUsername").value.trim(); |
There was a problem hiding this comment.
Use React Hooks like useState instead of Vanilla JS
There was a problem hiding this comment.
I have updated login form. Please. review now.
| const addTask = (e) => { | ||
| e.preventDefault() | ||
| if (!Todotxt || Todotxt=="") { | ||
| return; |
There was a problem hiding this comment.
Should have added some Error or Warning Toast
There was a problem hiding this comment.
Added error message in add task. Please, review again.
components/TodoListItem.js
Outdated
| * @todo 2. Update the task in the dom. | ||
| */ | ||
| if (!Newdata) { | ||
| return; |
There was a problem hiding this comment.
Added warning toast in update method. Please, review again.
Added error message.
Used react hooks!
Added error message in update method!
Passed functions to no_auth_required.js !
Added function to redirect user to homepage!
Sorry for changes again, now finally added warning message.
CSOC Task 3 Submission
I have completed the following tasks
auth_required.jsandno_auth_required.js