Completed The Tasks #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KKVANONYMOUS
requested changes
Jul 5, 2021
middlewares/auth_required.js
Outdated
| /*** | ||
| * @todo Redirect the user to login page if token is not present. | ||
| */ | ||
| const checkLogin = () => { | ||
| // console.log(document.cookie); | ||
| if(document.cookie=='')window.location.href = './login' |
There was a problem hiding this comment.
Make use of Framework specific methods rather than using Vanilla JS one
There was a problem hiding this comment.
So I have to use router instead of window.location.href and rather than checking document.cookie again and again I should use State ??
Is that all or I am still missing something?
There was a problem hiding this comment.
I made a few changes to resolve those mistakes. Please review them.
| } | ||
| const API_BASE_URL = 'https://todo-app-csoc.herokuapp.com/' | ||
| const dataForApiRequest = { | ||
| username: document.getElementById('inputUsername').value, |
There was a problem hiding this comment.
You should have make use of React Hooks like useState to manage the states
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSOC Task 3 Submission
I have completed the following tasks
auth_required.jsandno_auth_required.js