Initial commit #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
K-Kumar-01
approved these changes
Aug 23, 2021
Comment on lines
+12
to
+18
| const [createdTodos, collaboratedTodos] = await Promise.all([ | ||
| ToDo.find({ createdBy: req.user._id }).select("_id title"), | ||
| ToDo.find({ | ||
| collaborators: req.user._id, | ||
| }).select("_id title"), | ||
| , | ||
| ]); |
There was a problem hiding this comment.
use Mongodb $or mehthod for this.
| const { title } = req.body; | ||
| if (title == null) throw new BackendError(400, "Title is required"); | ||
| if (!title) throw new BackendError(400, "Title cannot be blank"); | ||
| const newTodo = new ToDo({ title, createdBy: req.user._id }); |
There was a problem hiding this comment.
use exec commands they slightly increase the speed.
Comment on lines
+1
to
+8
| class BackendError extends Error { | ||
| constructor(statusCode = 500, message = "An error occurred") { | ||
| super(); | ||
| this.message = message; | ||
| this.statusCode = statusCode; | ||
| } | ||
| } | ||
| module.exports = BackendError; |
Comment on lines
+35
to
+36
| if (username == null) throw new BackendError(400, "Username is required"); | ||
| if (!username) throw new BackendError(400, "Username cannot be blank"); |
There was a problem hiding this comment.
combine them into one. Also, " " will pass both the tests. Be sure to check these cases.
Comment on lines
+6
to
+8
| todo.collaborators | ||
| .filter((user) => (user ? true : false)) | ||
| .some((userId) => userId.toString() == id); |
There was a problem hiding this comment.
use todo.collaborators.includes() instead of the above.
| // All the given method require token. | ||
| // So be sure to check for it before doing any stuff | ||
| // HINT: Create a middleware for above :) | ||
| const isCreater = (todo, id) => todo.createdBy.toString() == id; |
There was a problem hiding this comment.
Use strict equality checkers.
|
Marks: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have completed these tasks
For TASK 2, I have used username because sharing username is easier than sharing ID
Request Object (Sample):