libpressio version 0.56.0

Breaking Change + metrics now provide a default implementation of {begin,end}_{de,}compress_many which defaults to calling {begin,end}_{de,}compress. This eases some of the implementation of metrics that support being called from `_many` contexts + the default implementation of compress_many now calls compress_impl instead of compress.
CODARcode · Jan 19, 2021 · a3a02d8 · a3a02d8
1 parent 3af4b64
commit a3a02d8
Show file tree

Hide file tree

Showing 4 changed files with 27 additions and 15 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -1,5 +1,5 @@
 cmake_minimum_required(VERSION 3.13 FATAL_ERROR)
-project(libpressio VERSION "0.55.3" LANGUAGES CXX C)
+project(libpressio VERSION "0.56.0" LANGUAGES CXX C)
 
 #correct was to set a default build type
 # https://blog.kitware.com/cmake-and-the-default-build-type/

diff --git a/COPYRIGHT.txt b/COPYRIGHT.txt
@@ -1,6 +1,6 @@
 Copyright © 2021 , UChicago Argonne, LLC
 All Rights Reserved
-[libpressio, Version 0.55.3]
+[libpressio, Version 0.56.0]
 Robert Underwood
 Argonne National Laboratory
 

diff --git a/include/libpressio_ext/cpp/compressor.h b/include/libpressio_ext/cpp/compressor.h
@@ -251,7 +251,7 @@ class libpressio_compressor_plugin :public pressio_configurable, public pressio_
   virtual int decompress_many_impl(compat::span<const pressio_data* const> const& inputs, compat::span<pressio_data* >& outputs) {
     //default returns an error to indicate the option is unsupported;
     if(inputs.size() == 1 && outputs.size() == 1) {
-      return decompress(inputs.front(), outputs.front());
+      return decompress_impl(inputs.front(), outputs.front());
     } else 
     return set_error(1, "decompress_many not supported");
   }
@@ -262,7 +262,7 @@ class libpressio_compressor_plugin :public pressio_configurable, public pressio_
   virtual int compress_many_impl(compat::span<const pressio_data* const> const& inputs, compat::span<pressio_data*> & outputs) {
     //default returns an error to indicate the option is unsupported;
     if(inputs.size() == 1 && outputs.size() == 1) {
-      return compress(inputs.front(), outputs.front());
+      return compress_impl(inputs.front(), outputs.front());
     } else 
     return set_error(1, "decompress_many not supported");
   }

diff --git a/src/plugins/metrics/metrics_base.cc b/src/plugins/metrics/metrics_base.cc
@@ -26,17 +26,29 @@ void libpressio_metrics_plugin::begin_decompress(struct pressio_data const*, pre
 }
 void libpressio_metrics_plugin::end_decompress(struct pressio_data const*, pressio_data const*, int) {
 }
-void libpressio_metrics_plugin::begin_compress_many(compat::span<const pressio_data* const> const&,
-                                 compat::span<const pressio_data* const> const&) {
-}
-void libpressio_metrics_plugin::end_compress_many(compat::span<const pressio_data* const> const& ,
-                                 compat::span<const pressio_data* const> const& , int ) {
-}
-void libpressio_metrics_plugin::begin_decompress_many(compat::span<const pressio_data* const> const& ,
-                                 compat::span<const pressio_data* const> const& ) {
-}
-void libpressio_metrics_plugin::end_decompress_many(compat::span<const pressio_data* const> const&,
-                                 compat::span<const pressio_data* const> const& , int) {
+void libpressio_metrics_plugin::begin_compress_many(compat::span<const pressio_data* const> const& inputs,
+                                 compat::span<const pressio_data* const> const& outputs) {
+  if(inputs.size() == 1 && outputs.size() == 1) {
+    begin_compress(inputs.front(), outputs.front());
+  }
+}
+void libpressio_metrics_plugin::end_compress_many(compat::span<const pressio_data* const> const& inputs,
+                                 compat::span<const pressio_data* const> const& outputs, int rc) {
+  if(inputs.size() == 1 && outputs.size() == 1) {
+    end_compress(inputs.front(), outputs.front(), rc);
+  }
+}
+void libpressio_metrics_plugin::begin_decompress_many(compat::span<const pressio_data* const> const& inputs,
+                                 compat::span<const pressio_data* const> const& outputs) {
+  if(inputs.size() == 1 && outputs.size() == 1) {
+    begin_decompress(inputs.front(), outputs.front());
+  }
+}
+void libpressio_metrics_plugin::end_decompress_many(compat::span<const pressio_data* const> const& inputs,
+                                 compat::span<const pressio_data* const> const& outputs, int rc) {
+  if(inputs.size() == 1 && outputs.size() == 1) {
+    end_decompress(inputs.front(), outputs.front(), rc);
+  }
 }
 
 void libpressio_metrics_plugin::set_name(std::string const& new_name) {