Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Travis Continuous Integration to the repo #86

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

peternewman
Copy link
Contributor

@peternewman peternewman commented Jun 28, 2018

To catch careless typos etc.

You'll need to enable Travis on the repo (https://travis-ci.com is now the recommended option), and I'd then suggest you protect the branch in GitHub so you can only merge if Travis passes.

Currently this is just testing against the some Teensy version, we could test against a lot more variations if it's worth it (many examples, many platforms):
http://platformio.org/boards

We could also enable a C++ linter if you have a preferred one, or use cpplint.py from Google?

@peternewman
Copy link
Contributor Author

It's already found a pile of typos:
https://travis-ci.com/peternewman/OSC/jobs/131740761

@peternewman
Copy link
Contributor Author

Typos all fixed.

@peternewman
Copy link
Contributor Author

This now all passes apart from these two, which looks like genuine failures (on Teensy 3.5/6):
https://travis-ci.com/peternewman/OSC/jobs/134879442#L609
https://travis-ci.com/peternewman/OSC/jobs/134879447#L609

@peternewman
Copy link
Contributor Author

Hi @adrianfreed,

What's your feeling on this? Should Teensy 3.5/6 be supported? Are you expecting the UDPSendBundlewithTimeTag examples to work on those platforms?

Should I mark those as expected failures for now so the bulk of Travis can be merged in and the spelling fixes?

@peternewman peternewman changed the title Add Travis Continuous Integration to the repo Add Travis Continuous Integration to the repo and fix found spelling mistakes Sep 25, 2018
@peternewman peternewman mentioned this pull request Oct 1, 2018
@peternewman peternewman changed the title Add Travis Continuous Integration to the repo and fix found spelling mistakes Add Travis Continuous Integration to the repo Oct 29, 2018
Copy link
Member

@adrianfreed adrianfreed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too intrusive a change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants