Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 important(?) definition fixes. And some documentation bug fixes #40

Merged
merged 7 commits into from
Jan 9, 2025

Conversation

jpolton
Copy link
Contributor

@jpolton jpolton commented Jan 7, 2025

updated

  1. Found one coding error:
  • MK4 coefficient was specified as nu' instead of nu'' (see 1st screenshot- Schureman)
  1. Source citation clarification:
  • M4 nodal factor is f(M2) as Schureman is in error. The correct source is Pugh 87 (compare screenshots. 2nd screenshot: Pugh 87. The first screenshot is Schureman)
    image
Screenshot 2025-01-09 at 13 07 38
  1. Also found a small number of typos in the documentation for variable values and spelling.

Comment typos in nodal factor definitions
nu' assigned instead of nu''
M4 nodal factor was not squared
Wrong Schureman equation cited
Typos in markdown comments: coefficients and formulae. However coefficients are correctly computed and defined in code.
include/fes/wave.hpp Outdated Show resolved Hide resolved
@fbriol
Copy link
Collaborator

fbriol commented Jan 9, 2025

Thank you very much for your contribution.

@fbriol fbriol merged commit b1d5041 into CNES:main Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants