WIP added calculateTimeSinceEdit, moment.js error still needs to be fixed #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evelyn-lo
changed the title
Fixed moment.js error, timeElapsed since edit displayed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14
Tried to display time elapsed (etc: 2 minutes ago, 3 hrs ago, 4 days ago) after edits
Encountered error "moment is not defined" in backend (edit.js) and frontend (event.js)
npm list momentOutput:
verified moment work in Node.js by running `node -e "console.log(require('moment')().format())"
Output: node -e "console.log(require('moment')().format())"
This confirmed that moment was correctly installed but not properly imported in NodeBB
backend fix (src/posts/edit.js) added required moment import:
const moment = require('moment');front end fix (public/src/client/topic/event.js) addedconst moment = window.moment || require('moment');