Add forecast classes #1115

peanutfun · 2025-11-21T17:26:10Z

Changes proposed in this PR:

Add forecast variants for Hazard and Impact.
Adapt ImpactCalc to return ImpactForecast when needed.
Add tests.
Add tutorial for forecast data.

This PR resolves a major portion of #1118. Note that sub-tasks have been marked as completed when merged into this branch.

PR Author Checklist

PR Reviewer Checklist

* define base class * add init test * Fix #1127 --------- Co-authored-by: Valentin Gebhart <[email protected]> Co-authored-by: Lukas Riedel <[email protected]>

* Add ImpactForecast * Add unit tests

* Create hazardForecast base class * Update datetime to timedelta for lead_time * Add tests --------- Co-authored-by: luseverin <[email protected]> Co-authored-by: Lukas Riedel <[email protected]>

* change leadtime to timedelta * adapt impactforecast docstrings and tests * Remove stray comment --------- Co-authored-by: Lukas Riedel <[email protected]>

* Add HazardForecast.select test --------- Co-authored-by: luseverin <[email protected]> Co-authored-by: Lukas Riedel <[email protected]>

* Add test for hazardForecast.concat * Skip HazardForecast.concat test --------- Co-authored-by: luseverin <[email protected]> Co-authored-by: Lukas Riedel <[email protected]>

* Add test for ImpactForecast.select * minor test modification --------- Co-authored-by: Evelyn Mühlhofer <[email protected]>

* Add test stub for ImpactForecast.concat * Use correct command for skipping a test * Fix merge issue

* Add data shape check for HazardForecast, ImpactForecast

Adapt Hazard from_hdf5 and write_hdf5 to forecast attributes

* Add extended select impact forecast test * Add extended hazard forecast test --------- Co-authored-by: Chahan Kropf <[email protected]> Co-authored-by: Lukas Riedel <[email protected]>

* Return impactForecast object in _return_impact * Return impactForecast object in _return_empty * Add full impactcalc test for impactForecast * Raise value error when computing impact with impact forecast without saving impact matrix * Cosmetics: Improve error message, move test to own class * Write nans for eai_exp and aai_agg when forecast is used --------- Co-authored-by: luseverin <[email protected]> Co-authored-by: Chahan Kropf <[email protected]> Co-authored-by: Lukas Riedel <[email protected]>

* add idx boolean selection for member and leadtime * Add test for weird data types --------- Co-authored-by: Lukas Riedel <[email protected]>

* Add ImpactForecast.select --------- Co-authored-by: Lukas Riedel <[email protected]>

* add HazardForecast.select and extent test --------- Co-authored-by: Eliane Kobler <[email protected]> Co-authored-by: Lukas Riedel <[email protected]>

* Add HazardForecast.concat

Add min/mean/max methods --------- Co-authored-by: luseverin <[email protected]> Co-authored-by: Chahan Kropf <[email protected]> Co-authored-by: Lukas Riedel <[email protected]>

* Make Impact.concat support ImpactForecast * Add tests

* implement changes in Impact IO and ImpactForecast IO * Update tests * Fix small issue when reading H5 for ImpactForecast --------- Co-authored-by: Lukas Riedel <[email protected]>

* Add quantile and median for hazard and impact forecast * Review --------- Co-authored-by: luseverin <[email protected]> Co-authored-by: Chahan Kropf <[email protected]> Co-authored-by: Lukas Riedel <[email protected]>

…ython into forecast-class

* Add impact forecast tutorial * Add 'dim' argument to reductions * Update tests --------- Co-authored-by: Lukas Riedel <[email protected]> Co-authored-by: luseverin <[email protected]> Co-authored-by: Evelyn Mühlhofer <[email protected]> Co-authored-by: Chahan Kropf <[email protected]>

…ython into forecast-class

climada/engine/test/test_impact_calc.py

peanutfun · 2026-02-04T09:00:15Z

@Evelyn-M How was the fcst_icon_seamless_2024-06-18_12_00.nc test file created? I see that it's in a different CRS than the "latest" example files downloaded in the tutorial.

Evelyn-M · 2026-02-04T09:53:39Z

@Evelyn-M How was the fcst_icon_seamless_2024-06-18_12_00.nc test file created? I see that it's in a different CRS than the "latest" example files downloaded in the tutorial.

I downloaded it from the meteoswiss-internal data storage, since the API only permits downloads until -24 hrs.

peanutfun · 2026-02-05T12:39:36Z

So it had been reprojected? Does MCH store the data differently than OGD? I am just wondering because it might be important to highlight the caveats when importing datasets with varying CRS and coordinate specifications.

Evelyn-M · 2026-02-05T12:54:38Z

I suppose so, yes. One is the MCH grid commonly used internally for national gridded forecast products, and the OGD data has a different grid and a much larger rectangular extent around Switzerland.

peanutfun and others added 21 commits November 21, 2025 18:23

Forecast templates

ad819f2

Clean slate for Forecast

abafba4

1127 - Forecast base class init (#1167)

1688641

* define base class * add init test * Fix #1127 --------- Co-authored-by: Valentin Gebhart <[email protected]> Co-authored-by: Lukas Riedel <[email protected]>

Impact forecast class (#1168)

d66c8dd

* Add ImpactForecast * Add unit tests

Hazard forecast class (#1171)

35f9517

* Create hazardForecast base class * Update datetime to timedelta for lead_time * Add tests --------- Co-authored-by: luseverin <[email protected]> Co-authored-by: Lukas Riedel <[email protected]>

Change leadtime from datetime to timedelta (#1172)

54bb592

* change leadtime to timedelta * adapt impactforecast docstrings and tests * Remove stray comment --------- Co-authored-by: Lukas Riedel <[email protected]>

Hazard forecast test select (#1175)

4aaad4e

* Add HazardForecast.select test --------- Co-authored-by: luseverin <[email protected]> Co-authored-by: Lukas Riedel <[email protected]>

Hazard forecast concat test (#1178)

d04fecf

* Add test for hazardForecast.concat * Skip HazardForecast.concat test --------- Co-authored-by: luseverin <[email protected]> Co-authored-by: Lukas Riedel <[email protected]>

Check if Impact.select works on ImpactForecast (#1170)

d3cc83a

* Add test for ImpactForecast.select * minor test modification --------- Co-authored-by: Evelyn Mühlhofer <[email protected]>

Check if Impact.concat works on ImpactForecast (#1174)

a386d22

* Add test stub for ImpactForecast.concat * Use correct command for skipping a test * Fix merge issue

adapt from_hdf5 and write_hdf5

34612c5

Check sizes of forecast data vs. Hazard and Impact (#1180)

8a63b43

* Add data shape check for HazardForecast, ImpactForecast

implement code review

e123b7b

add comment to test

9ce7f73

Merge pull request #1181 from CLIMADA-project/adapt_hdf5_write_from

48b6d40

Adapt Hazard from_hdf5 and write_hdf5 to forecast attributes

Forecast/select extended tests (#1182)

64da484

* Add extended select impact forecast test * Add extended hazard forecast test --------- Co-authored-by: Chahan Kropf <[email protected]> Co-authored-by: Lukas Riedel <[email protected]>

add idx boolean selection for member and leadtime (#1183)

9d6fef9

* add idx boolean selection for member and leadtime * Add test for weird data types --------- Co-authored-by: Lukas Riedel <[email protected]>

Add select to ImpactForecast (#1188)

b17bcc9

* Add ImpactForecast.select --------- Co-authored-by: Lukas Riedel <[email protected]>

Add select method to HazardForecast (#1185)

302be63

* add HazardForecast.select and extent test --------- Co-authored-by: Eliane Kobler <[email protected]> Co-authored-by: Lukas Riedel <[email protected]>

Make Impact.concat support ImpactForecast

85b92ef

peanutfun force-pushed the forecast-class branch from 85b92ef to 302be63 Compare December 10, 2025 13:29

peanutfun and others added 8 commits December 10, 2025 14:32

Add HazardForecast.concat (#1184)

52edc45

* Add HazardForecast.concat

Implement mean min max for impact forecast and hazard forecast (#1187)

2b9b388

Add min/mean/max methods --------- Co-authored-by: luseverin <[email protected]> Co-authored-by: Chahan Kropf <[email protected]> Co-authored-by: Lukas Riedel <[email protected]>

Support ImpactForecast.concat (#1192)

bb99794

* Make Impact.concat support ImpactForecast * Add tests

Add hdf5 IO for ImpactForecast (#1190)

0e7857f

* implement changes in Impact IO and ImpactForecast IO * Update tests * Fix small issue when reading H5 for ImpactForecast --------- Co-authored-by: Lukas Riedel <[email protected]>

Merge branch 'forecast-class' of github.com:CLIMADA-project/climada_p…

d84db1e

…ython into forecast-class

Merge branch 'forecast-class' of github.com:CLIMADA-project/climada_p…

99e82a1

…ython into forecast-class

peanutfun changed the title ~~Forecast classes~~ Add forecast classes Jan 12, 2026

peanutfun marked this pull request as ready for review January 12, 2026 13:54

peanutfun requested review from chahank and emanuel-schmid as code owners January 12, 2026 13:54

peanutfun commented Jan 12, 2026

View reviewed changes

climada/engine/test/test_impact_calc.py Outdated Show resolved Hide resolved

peanutfun added 2 commits January 12, 2026 14:57

Apply suggestion from @peanutfun

38df263

Update CHANGELOG.md

a0fd081

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add forecast classes #1115

Add forecast classes #1115

peanutfun commented Nov 21, 2025 •

edited

Loading

Uh oh!

Uh oh!

peanutfun commented Feb 4, 2026

Uh oh!

Evelyn-M commented Feb 4, 2026

Uh oh!

peanutfun commented Feb 5, 2026

Uh oh!

Evelyn-M commented Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Add forecast classes #1115

Are you sure you want to change the base?

Add forecast classes #1115

Conversation

peanutfun commented Nov 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR Author Checklist

PR Reviewer Checklist

Uh oh!

Uh oh!

peanutfun commented Feb 4, 2026

Uh oh!

Evelyn-M commented Feb 4, 2026

Uh oh!

peanutfun commented Feb 5, 2026

Uh oh!

Evelyn-M commented Feb 5, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

peanutfun commented Nov 21, 2025 •

edited

Loading