Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document point() in all triangulations #8658

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Document point() in all triangulations #8658

wants to merge 6 commits into from
+82 −28

Conversation

MaelRL
Copy link
Member

@MaelRL MaelRL commented Dec 13, 2024

Summary of Changes

point(Vertex_handle) and point(Simplex, int) was only documented in few triangulations (T3, ToS2), but exist in (almost, P4HT2 is the exception) all triangulations.

This PR documents it where the functions exist, as they are useful to create packages that are triangulation-agnostic, such as alpha shapes.

Release Management

  • Affected package(s): Triangulations
  • Issue(s) solved (if any): -
  • Feature/Small Feature (if any): TODO
  • Link to compiled documentation (obligatory for small feature) wrong link name to be changed
  • License and copyright ownership: no change

@MaelRL MaelRL added this to the 6.1-beta milestone Dec 13, 2024
@sloriot
Copy link
Member

sloriot commented Dec 23, 2024

Successfully tested in CGAL-6.1-Ic-45

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CHANGES.md not updated Not yet approved The feature or pull-request has not yet been approved. Pkg::Hyperbolic_triangulation_2 Pkg::Periodic_2_Triangulation_2 Pkg::Periodic_3_Triangulation_3 Pkg::Triangulation_2 Small feature Tested
Projects
None yet
Milestone
6.1-beta
Development

Successfully merging this pull request may close these issues.
2 participants
@MaelRL @sloriot