QFunction multi source support #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YohannDudouit
previously requested changes
Nov 10, 2021
|
This one change should be ready to merge. Future changes related to the design of GPU backends can be captured in the refactor discussed in #839. |
nbeams
approved these changes
Nov 18, 2021
There was a problem hiding this comment.
I'm fine with this as a step to go ahead and add the desired new feature (multi-file QFunction support) while limiting the scope of the PR. At first I wasn't sure how I felt about elevating the LoadSourceToBuffer to the interface level since it's only used for GPU backends, but we already do that in, e.g., CeedVectorSyncArray, which is only really needed for GPU backends, as well, so I think it's fine.
jeremylt
force-pushed
the
jeremy/qf-multi-source
branch
from
1967cb5 to
30601ac
Compare
jedbrown
approved these changes
Nov 18, 2021
Co-authored-by: Jed Brown <[email protected]>
Co-authored-by: Jed Brown <[email protected]>
jeremylt
force-pushed
the
jeremy/qf-multi-source
branch
from
f5c7dae to
b44031f
Compare
jeremylt
dismissed
YohannDudouit’s stale review
design to return null pointer when property not present consistent with rest of interface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for multiple QFunction source files.
See the new
t406-qfunctionfor usage.I think further downstream consequences of the new
CeedLoadSourceToBuffer()should be put in a downstream PR.This the bulk of what was in #826, but with some of the possible downstream changes removed. The minor changes to the debugging macros went into #840.