Add fom variables to adiak#57
Merged
vladotomov merged 3 commits intoCEED:masterfrom Mar 31, 2026
Merged
Conversation
Contributor
Author
pearce8
suggested changes
Mar 20, 2026
|
|
||
| MPI_Comm adiak_mpi_comm = MPI_COMM_WORLD; | ||
| void* adiak_mpi_comm_ptr = &adiak_mpi_comm; | ||
| adiak::init(adiak_mpi_comm_ptr); |
There was a problem hiding this comment.
We should use adiak::collect_all() here to collect all the built-in metadata. It will collect the launch date and job size for you. Docs here: https://software.llnl.gov/Adiak/ApplicationAPI.html#_CPPv411collect_allv
There was a problem hiding this comment.
@rfhaque please add the adiak::collect_all() and test.
Contributor
Author
There was a problem hiding this comment.
@pearce8 Both the changes adiak::collect_all() and public MassBasedAvg::MassesAndVolumesAtPosition have been tested. Please review and merge
Contributor
Author
|
@vladotomov Please review |
vladotomov
approved these changes
Mar 26, 2026
pearce8
approved these changes
Mar 30, 2026
|
@vladotomov Please merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR
MassBasedAvg::MassesAndVolumesAtPositioninremhos_lo.hpppublic