Use inject for non singleton class

[jorg3lopez]

Description

This PR adds the logic necessary for non-singleton classes to use the @Inject annotation.

Changes

ApplicationContext.java

• Refactoring of skipMissingImplementation logic
• Renamed injectRegisteredImplementations -> doInjectRegisteredImplementations
• Overload injectIntoField method
• Added injectIntoNonSingleton() method

Reflections.java

• Added getFieldsAnnotatedWithInstance

ApplicationContextText.groovy

• Added test cases

TestApplicationContext.java

• Added skipMissingImplementation logic

HapiFhirResource

• The changes in this file were used for testing, they will get deleted once the PR is approved

HapiFhirResourceTest

• This file was used for testing, it will get deleted once the PR is approved

Testing

• Choose a non-singleton class to work with. Make sure the class is not dynamically instantiated
• Use @Inject on fields that you want to inject the dependency
• Make sure the class sends itself as a parameter toApplicationContext.injectIntoNonSingleton(), using the constructor
• Build module and make sure all tests pass

Issue

#1361

Checklist

• I have added tests to cover my changes

Note: You may remove items that are not applicable

[github-actions]

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Recommended focus areas for review Exception Handling The method 'injectIntoField' throws a generic IllegalArgumentException for any exception during field injection. This could mask different issues like security or logical errors which might need different handling. Dependency Injection The use of 'ApplicationContext.injectIntoNonSingleton(this)' within the constructor might lead to issues with incomplete construction if the injected dependencies themselves depend on the partially constructed object.

[github-actions]

PR Code Suggestions ✨

Explore these optional code suggestions:

Category	Suggestion	Score
Possible issue	Prevent potential NullPointerException by checking if instance is null before setting a field Ensure that injectIntoField checks for null instance before attempting to set the field, to prevent NullPointerException. shared/src/main/java/gov/hhs/cdc/trustedintermediary/context/ApplicationContext.java [82] -field.set(instance, fieldImplementation); +if (instance != null) { + field.set(instance, fieldImplementation); +} Suggestion importance[1-10]: 8 Why: This suggestion correctly identifies a potential NullPointerException risk in the code and provides a solution to prevent it, enhancing the robustness of the method.	8
	Enhance robustness by ensuring the annotation parameter is a valid subclass of Annotation Modify getFieldsAnnotatedWithInstance to handle the case where the annotation parameter is not a subclass of Annotation, to avoid a potential ClassCastException. shared/src/main/java/gov/hhs/cdc/trustedintermediary/context/Reflection.java [36] -.filter(field -> field.isAnnotationPresent(annotation.asSubclass(Annotation.class))) +.filter(field -> Annotation.class.isAssignableFrom(annotation) && field.isAnnotationPresent(annotation.asSubclass(Annotation.class))) Suggestion importance[1-10]: 7 Why: The suggestion accurately addresses a potential ClassCastException by checking if the annotation parameter is a valid subclass of Annotation before casting, thus improving the method's safety.	7
General	Improve stability by handling potential injection failures gracefully Add error handling for the injectIntoNonSingleton method in the constructor to manage potential injection failures gracefully. shared/src/main/java/gov/hhs/cdc/trustedintermediary/external/hapi/HapiFhirResource.java [16] -ApplicationContext.injectIntoNonSingleton(this); +try { + ApplicationContext.injectIntoNonSingleton(this); +} catch (Exception e) { + logger.error("Injection failed", e); +} Suggestion importance[1-10]: 6 Why: This suggestion proposes adding error handling around the injection process to manage failures more gracefully, which is a good practice for improving the reliability of the application.	6
	Provide clearer diagnostics by handling null implementations more informatively Add logging or throw a more specific exception when fieldImplementation is null, to provide clearer diagnostics when injection fails. shared/src/main/java/gov/hhs/cdc/trustedintermediary/context/ApplicationContext.java [76-77] if (fieldImplementation == null) { - return; + throw new IllegalStateException("No implementation found for " + fieldType); } Suggestion importance[1-10]: 5 Why: The suggestion to throw a more specific exception when an implementation is not found is beneficial for debugging and understanding injection failures, although it could be improved by also including logging before throwing the exception.	5

[sonarqubecloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud