Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameter to force target debug console from server's config #1364

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add parameter to force target debug console from server's config #1364

wants to merge 5 commits into from

Conversation

TheShinriel
Copy link

When merged this pull request will:

  • Add category "CBA Tools" for addon's options
  • Add addon's options "forceTargetDebug"
    • Will start the target debug console even if there is the mission's parameter is not selected, allowing to force this tool from server's configuration
    • The console will appear directly, but mission must be restarted to take into account the variables
  • Fix CBA_fn_addSetting parameter _isGlobal, based on the param in the script

commy2
commy2 reviewed Aug 24, 2020
View reviewed changes
addons/diagnostic/stringtable.xml Outdated
@@ -92,5 +92,9 @@
<Italian>[CBA] Abilita il debug remoto. Richiede la console di debug.</Italian>
<Czech>[CBA] Povoluje ladění vzdáleného cíle. Vyžaduje ladící konzoli.</Czech>
</Key>
<Key ID="STR_cba_diagnostic_ForceTargetDebug">
<English>Force target debugging for all missions</English>
<French>Forcer le débogage de la cible pour toutes les missions</French>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Periods after sentences.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you mean dots? Fix soon

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Period as in full stop
.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed, to use the same text as the option in Eden

@commy2
Copy link
Contributor

commy2 commented Aug 24, 2020

  • Why "force" though? Why not EnableTargetDebug like the other switches? They are disjunct with none having any priority whatsoever.

  • Category could be Debug or probably better yet Diagnositic, to correspond to the component (less invented terminology).

PabstMirror
PabstMirror reviewed Aug 24, 2020
View reviewed changes
addons/diagnostic/XEH_preInit.sqf Outdated
@@ -18,7 +20,7 @@ GVAR(projectileTrackedUnits) = [];

ADDON = true;

if (getMissionConfigValue ["EnableTargetDebug", 0] == 1 || {getNumber (configFile >> "EnableTargetDebug") == 1}) then {
if (getMissionConfigValue ["EnableTargetDebug", 0] == 1 || {getNumber (configFile >> "EnableTargetDebug") == 1} || {GVAR(forceTargetDebug)}) then {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this happens before settings are initialized

Copy link
Author

@TheShinriel TheShinriel Aug 24, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#include "initSettings.sqf"
Is called before, to init the settings.
I have tested solo and multi with and without the option on mission without the mission's config selected, that worked great

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The global variable is definitely not synchronized from the server at preInit. This is a global setting. Try on a server as dedicated client.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will test more with a dedicated client and a dedicated server
I could add a waitUntil in the condition, not executed if mission is set to true, however, it will wait the synchronizatio... still have to check what variable I can watch to know when it's done

Thx for the explanation.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oki added a commit, that wait the event CBA_settingsInitialized event

@TheShinriel
Copy link
Author

  • Why "force" though? Why not EnableTargetDebug like the other switches? They are disjunct with none having any priority whatsoever.
  • Category could be Debug or probably better yet Diagnositic, to correspond to the component (less invented terminology).
  • Force, was because of the existance
    • "force" because of the existing, that option will ignore the configuration of the mission. But indeed, by looking the option, could have sens alone.
  • I will rename for "Diagnositic"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@commy2 commy2 Awaiting requested review from commy2

@PabstMirror PabstMirror Awaiting requested review from PabstMirror

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@TheShinriel @commy2 @PabstMirror