v0 of find_minimal_coverage #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcollman
added
Status: In Progress
Type: New Feature
and removed
Status: In Progress
labels
|
I think this is done now. |
fcollman
force-pushed
the
cover_minimal_nodes
branch
from
b66cdb1 to
e1288ab
Compare
fcollman
commented
Dec 4, 2024
| @@ -11,7 +11,7 @@ flask | |||
| flask_cors | |||
| python-json-logger | |||
| redis | |||
| rq | |||
| rq<2 | |||
There was a problem hiding this comment.
I noticed this was a problem when trying to get a local version of PCG running and so i added it here pre-emptively to save us time in the future when we try to recompile reqs.
There was a problem hiding this comment.
I think this is fine for now, version 2 was released only recently in Oct.
akhileshh
reviewed
Dec 4, 2024
akhileshh
approved these changes
Dec 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
not completed yet complete, but scaffold of endpoint to find minimal set of nodes that covers all passed in nodes